Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FINERACT-821 Added and Enforced MethodName Checkstyle #986

Merged
merged 1 commit into from
Jun 7, 2020
Merged

FINERACT-821 Added and Enforced MethodName Checkstyle #986

merged 1 commit into from
Jun 7, 2020

Conversation

thesmallstar
Copy link
Member

This is nearly final, will do one more review.

@thesmallstar thesmallstar marked this pull request as draft June 5, 2020 22:34
@thesmallstar thesmallstar marked this pull request as ready for review June 6, 2020 23:50
@thesmallstar
Copy link
Member Author

@awasum @vorburger @xurror review this?

vorburger
vorburger approved these changes Jun 7, 2020
View reviewed changes
Copy link
Member

@vorburger vorburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vorburger vorburger merged commit b0ff8db into apache:develop Jun 7, 2020
@thesmallstar thesmallstar mentioned this pull request Jun 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vorburger vorburger vorburger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thesmallstar @vorburger