adjust based on pr

apache · May 9, 2024 · 07929ae · 07929ae
1 parent 6196a59
commit 07929ae
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/...oser/src/main/java/org/apache/flink/cdc/composer/flink/translator/DataSinkTranslator.java b/...oser/src/main/java/org/apache/flink/cdc/composer/flink/translator/DataSinkTranslator.java
@@ -72,9 +72,8 @@ public void translate(
         }
     }
 
-    /** Only visible for test */
     @VisibleForTesting
-    protected void sinkTo(
+    void sinkTo(
             DataStream<Event> input,
             Sink<Event> sink,
             String sinkName,

diff --git a/.../src/test/java/org/apache/flink/cdc/composer/flink/translator/DataSinkTranslatorTest.java b/.../src/test/java/org/apache/flink/cdc/composer/flink/translator/DataSinkTranslatorTest.java
@@ -45,6 +45,7 @@ public void testPreWriteWithoutCommitSink() {
         DataStreamSource<Event> inputStream = env.fromCollection(mockEvents);
         DataSinkTranslator translator = new DataSinkTranslator();
 
+        // Node hash must be a 32 character String that describes a hex code
         String uid = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
         MockPreWriteWithoutCommitSink mockPreWriteWithoutCommitSink =
                 new MockPreWriteWithoutCommitSink(uid);
@@ -53,6 +54,9 @@ public void testPreWriteWithoutCommitSink() {
                 mockPreWriteWithoutCommitSink,
                 "testPreWriteWithoutCommitSink",
                 new OperatorID());
+
+        // Check if the `addPreWriteTopology` is called, and the uid is set when the transformation
+        // added
         OneInputTransformation<Event, Event> oneInputTransformation =
                 (OneInputTransformation) env.getTransformations().get(0);
         Transformation<?> reblanceTransformation = oneInputTransformation.getInputs().get(0);