[mysql] Support starting reading binlog from earliest offset / specific offset / timestamp #1661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardBang
reviewed
Oct 26, 2022
There was a problem hiding this comment.
@PatrickRen Thanks for the contribution, Could you fix the compile issue firstly?
PatrickRen
force-pushed
the
mysql-starting-offset
branch
3 times, most recently
from
a3b29ca
to
1446ad8
Compare
leonardBang
reviewed
Oct 27, 2022
There was a problem hiding this comment.
Thanks @PatrickRen for the contribution, I left some comments. Please update the connector docs as well.
...src/main/java/com/ververica/cdc/connectors/mysql/debezium/task/MySqlBinlogSplitReadTask.java
Outdated
Show resolved
Hide resolved
...n/java/com/ververica/cdc/connectors/mysql/debezium/task/context/ChangeEventCreatorUtils.java
Outdated
Show resolved
Hide resolved
...-cdc/src/main/java/com/ververica/cdc/connectors/mysql/source/offset/BinlogOffsetBuilder.java
Show resolved
Hide resolved
Comment on lines
34
to
49
| /** The binlog offset is described by a timestamp. */ | ||
| TIMESTAMP, | ||
|
|
||
| /** | ||
| * A specific offset described by binlog file name and position, or GTID set if GTID is enabled | ||
| * on the cluster. | ||
| */ | ||
| SPECIFIC, |
There was a problem hiding this comment.
We can given three examples for each kind in note.
...ql-cdc/src/main/java/com/ververica/cdc/connectors/mysql/source/offset/BinlogOffsetUtils.java
Outdated
Show resolved
Hide resolved
...ql-cdc/src/main/java/com/ververica/cdc/connectors/mysql/source/reader/MySqlSourceReader.java
Show resolved
Hide resolved
.../src/test/java/com/ververica/cdc/connectors/mysql/debezium/reader/BinlogSplitReaderTest.java
Show resolved
Hide resolved
.../src/test/java/com/ververica/cdc/connectors/mysql/debezium/reader/BinlogSplitReaderTest.java
Show resolved
Hide resolved
...tor-mysql-cdc/src/test/java/com/ververica/cdc/connectors/mysql/source/MySqlSourceITCase.java
Outdated
Show resolved
Hide resolved
...tor-mysql-cdc/src/test/java/com/ververica/cdc/connectors/mysql/source/MySqlSourceITCase.java
Outdated
Show resolved
Hide resolved
PatrickRen
force-pushed
the
mysql-starting-offset
branch
from
ef8b512
to
27ee38c
Compare
leonardBang
reviewed
Oct 29, 2022
…ic offset / timestamp (apache#1661) This closes apache#254
PatrickRen
force-pushed
the
mysql-starting-offset
branch
from
150c4f7
to
5d9878f
Compare
PatrickRen
force-pushed
the
mysql-starting-offset
branch
from
5d9878f
to
76aa5ad
Compare
leonardBang
approved these changes
Nov 1, 2022
This was referenced Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new feature #254 for the new MySQL CDC source, that users could specify starting point of binlog reading, including earliest offset, specific offset and timestamp.