[mysql] Use event filter to drop events earlier than the specified timestamp in timestamp startup mode #1724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickRen
force-pushed
the
event-timestamp-filter
branch
from
10971fc
to
74db2ca
Compare
leonardBang
reviewed
Nov 9, 2022
There was a problem hiding this comment.
Thanks @PatrickRen for the contribution, I left some comments
...-cdc/src/main/java/com/ververica/cdc/connectors/mysql/debezium/reader/BinlogSplitReader.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/ververica/cdc/connectors/mysql/debezium/task/context/MySqlErrorHandler.java
Outdated
Show resolved
Hide resolved
leonardBang
reviewed
Nov 9, 2022
.../src/test/java/com/ververica/cdc/connectors/mysql/debezium/reader/BinlogSplitReaderTest.java
Outdated
Show resolved
Hide resolved
leonardBang
approved these changes
Nov 9, 2022
leonardBang
approved these changes
Nov 9, 2022
…mestamp in timestamp startup mode (apache#1724)
…earliest but schema change happened before (apache#1724)
PatrickRen
force-pushed
the
event-timestamp-filter
branch
from
68d0da5
to
5ae25c8
Compare
PatrickRen
added a commit
to PatrickRen/flink-cdc
that referenced
this pull request
Nov 9, 2022
…mestamp in timestamp startup mode (apache#1724)
PatrickRen
added a commit
to PatrickRen/flink-cdc
that referenced
this pull request
Nov 9, 2022
…earliest but schema change happened before (apache#1724)
leonardBang
pushed a commit
that referenced
this pull request
Nov 9, 2022
…mestamp in timestamp startup mode (#1724)
leonardBang
pushed a commit
that referenced
this pull request
Nov 9, 2022
…earliest but schema change happened before (#1724)
leonardBang
pushed a commit
that referenced
this pull request
Nov 9, 2022
…mestamp in timestamp startup mode (#1724)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request reworks the logic of timestamp startup mode, which uses a event filter in
MySqlBinlogSplitReadTaskto drop events earlier than the specified startup timestamp.Compared to the previous implementation #1661 in which the filter was applied on
ChangeEventCreator, the filter is applied right after the binlog event is received, so that the diff in schema will not be complained by Debezium reader under the case that schema change happens before the specified timestamp.This PR also improves the error message under the case that starting from earliest offset but schema change happened before.