Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oracle cdc doc #1719

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Oracle cdc doc #1719

merged 1 commit into from
Nov 21, 2022

Conversation

molsionmo
Copy link
Contributor

No description provided.

@mergify
Copy link

mergify bot commented Nov 8, 2022

⚠️ The sha of the head commit of this PR conflicts with #1718. Mergify cannot evaluate rules on this PR. ⚠️

@mergify
Copy link

mergify bot commented Nov 8, 2022

⚠️ The sha of the head commit of this PR conflicts with #1718. Mergify cannot evaluate rules on this PR. ⚠️

<td>optional</td>
<td style="word-wrap: break-word;">3</td>
<td>Integer</td>
<td>The max retry times that the connector should retry to build MySQL database server connection.</td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MySQL?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this question have been solved @rinkako

@gtk96
Copy link
Contributor

gtk96 commented Nov 8, 2022

All tutorial docs the download link in should also be a snapshot version.

@mergify
Copy link

mergify bot commented Nov 9, 2022

⚠️ The sha of the head commit of this PR conflicts with #1718. Mergify cannot evaluate rules on this PR. ⚠️

@leonardBang
Copy link
Contributor

@molsionmo Could you rebase this PR to master as conflicts happened?

@molsionmo molsionmo force-pushed the oracle_doc branch 2 times, most recently from b69f83d to 26f3af4 Compare November 15, 2022 13:26
@molsionmo
Copy link
Contributor Author

@RookieGao please review again , thanks

@gtk96
Copy link
Contributor

gtk96 commented Nov 15, 2022

Thanks @molsionmo for the contribution, I left a little comment

@gtk96
Copy link
Contributor

gtk96 commented Nov 15, 2022

Note: flink-sql-connector-oracle-cdc-XXX-SNAPSHOT version is the code corresponding to the development branch. Users need to download the source code and compile the corresponding jar. Users should use the released version, such as flink-sql-connector-oracle-cdc-2.2.1.jar, the released version will be available in the Maven central warehouse.

We have released version 2.3. Can we update it here ?

@gtk96
Copy link
Contributor

gtk96 commented Nov 16, 2022

At present, the oracle connector can only read the source through a single thread ?

…shot framework for Oracle CDC Connector config
@molsionmo
Copy link
Contributor Author

Thank you for reminding of the problem. The connector have been support incremental snapshot in multiple concurrency . please review again , thanks.

@gtk96
Copy link
Contributor

gtk96 commented Nov 18, 2022

image

cc @leonardBang

Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @molsionmo and @RookieGao for the contribution, LGTM

@leonardBang leonardBang merged commit 00fea60 into apache:master Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants