Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix] Forward root cause in DebeziumSourceFunction #1791

Merged
merged 2 commits into from
Dec 5, 2022
Merged

[hotfix] Forward root cause in DebeziumSourceFunction #1791

merged 2 commits into from
Dec 5, 2022

Conversation

rmetzger
Copy link
Contributor

@rmetzger rmetzger commented Dec 2, 2022

In our production system, I've seen exceptions about rejected snapshots, but I was not able to find the root cause (e.g. the exception in the handover).
This change is adding the exception as the cause to the FlinkRuntimeException we throw in the snapshotState method.

@leonardBang leonardBang self-requested a review December 4, 2022 07:35
leonardBang
leonardBang approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rmetzger for the contribution, LGTM

@leonardBang leonardBang merged commit 8bf6160 into apache:master Dec 5, 2022
@rmetzger rmetzger deleted the forward_exceptions branch December 8, 2022 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardBang leonardBang leonardBang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rmetzger @leonardBang