Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix] Forward root cause in DebeziumSourceFunction #1791

Merged
merged 2 commits into from
Dec 5, 2022
Merged

[hotfix] Forward root cause in DebeziumSourceFunction #1791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0355283
[hotfix] Forward root cause in DebeziumSourceFunction
Dec 2, 2022
276aa18
spotless
Dec 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...k-connector-debezium/src/main/java/com/ververica/cdc/debezium/DebeziumSourceFunction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,8 @@ public void snapshotState(FunctionSnapshotContext functionSnapshotContext) throw
if (handover.hasError()) {
LOG.debug("snapshotState() called on closed source");
throw new FlinkRuntimeException(
"Call snapshotState() on closed source, checkpoint failed.");
"Call snapshotState() on closed source, checkpoint failed.",
handover.getError());
} else {
snapshotOffsetState(functionSnapshotContext.getCheckpointId());
snapshotHistoryRecordsState();
Expand Down
14 changes: 14 additions & 0 deletions flink-connector-debezium/src/main/java/com/ververica/cdc/debezium/internal/Handover.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import javax.annotation.Nullable;
import javax.annotation.concurrent.GuardedBy;
import javax.annotation.concurrent.ThreadSafe;

Expand Down Expand Up @@ -56,6 +57,7 @@ public class Handover implements Closeable {
private List<ChangeEvent<SourceRecord, SourceRecord>> next;

@GuardedBy("lock")
@Nullable
private Throwable error;

private boolean wakeupProducer;
Expand Down Expand Up @@ -161,6 +163,18 @@ public boolean hasError() {
return error != null;
}

/**
* Return the error, if its set.
*
* @return the error, if its set
*/
@Nullable
public Throwable getError() {
synchronized (lock) {
return this.error;
}
}

/**
* Closes the handover. Both the {@link #produce(List)} method and the {@link #pollNext()} will
* throw a {@link ClosedException} on any currently blocking and future invocations.
Expand Down