[cdc-common] Remove prefix of pipeline options #2821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we nee to change any test? 😶 |
leonardBang
reviewed
Dec 5, 2023
There was a problem hiding this comment.
Thanks @PatrickRen for the contribution, I left minor comments
flink-cdc-common/src/main/java/com/ververica/cdc/common/pipeline/PipelineOptions.java
Outdated
Show resolved
Hide resolved
flink-cdc-common/src/main/java/com/ververica/cdc/common/pipeline/PipelineOptions.java
Outdated
Show resolved
Hide resolved
flink-cdc-common/src/main/java/com/ververica/cdc/common/pipeline/PipelineOptions.java
Outdated
Show resolved
Hide resolved
leonardBang
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes prefix
pipeline.from pipeline options to simply user configurations.