-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Fix overview docs to remove prefix of pipeline options. #2833
Conversation
@PatrickRen , @ruanhang1993 , @lvyanquan , CC |
@@ -97,5 +97,5 @@ For example, we can use this yaml file to define a pipeline: | |||
```yaml | |||
pipeline: | |||
name: mysql-to-kafka-pipeline | |||
pipeline.global.parallelism: 1 | |||
global.parallelism: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just 'parallelism', not 'global.parallelism'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joyCurry30 , Thanks, I will remove it from cdc-pipeline.md
and mysql's pipeline-test.yaml
pipeline-test.yaml which under flink-cdc-pipeline-connector-mysql/src/test/resources has same problem. |
5f8c515
to
5d1a170
Compare
5d1a170
to
0e30fce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@loserwang1024 Thanks for the patch! LGTM.
0e30fce
to
4b9dceb
Compare
In #2821, prefix of pipeline options is removed. Thus, prefix of pipeline options in overview docs also need to be removed