Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-30426] Set archRule.failOnEmptyShould = false to return old behavior #7

Merged
merged 1 commit into from
Dec 15, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 8 additions & 2 deletions flink-connector-pulsar/archunit-violations/stored.rules
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
#
#Thu Mar 03 12:42:13 CST 2022
Tests\ inheriting\ from\ AbstractTestBase\ should\ have\ name\ ending\ with\ ITCase=3ac3a1dc-681f-4213-9990-b7b3298a20bc
#Thu Dec 15 11:39:06 CET 2022
Return\ and\ argument\ types\ of\ methods\ annotated\ with\ @Public\ must\ be\ annotated\ with\ @Public.=2a4fcdd8-60e4-4082-b57b-556a8f752e25
Connector\ production\ code\ must\ not\ depend\ on\ non-public\ API\ outside\ of\ connector\ packages=3d200b76-6b88-4f90-b43e-9b162ed73d16
ITCASE\ tests\ should\ use\ a\ MiniCluster\ resource\ or\ extension=f4d91193-72ba-4ce4-ad83-98f780dce581
Production\ code\ must\ not\ call\ methods\ annotated\ with\ @VisibleForTesting=aa1707ac-09b7-4467-973b-7223857d3409
Tests\ inheriting\ from\ AbstractTestBase\ should\ have\ name\ ending\ with\ ITCase=3ac3a1dc-681f-4213-9990-b7b3298a20bc
Options\ for\ connectors\ and\ formats\ should\ reside\ in\ a\ consistent\ package\ and\ be\ public\ API.=7e457e8d-a085-43cc-868c-fba88916032a
Return\ and\ argument\ types\ of\ methods\ annotated\ with\ @PublicEvolving\ must\ be\ annotated\ with\ @Public(Evolving).=a1d4eff3-5439-411c-9c89-a80f3ff0241d
Classes\ in\ API\ packages\ should\ have\ at\ least\ one\ API\ visibility\ annotation.=6a91e845-4388-460c-a448-42f7c0045e63
2 changes: 2 additions & 0 deletions flink-connector-pulsar/src/test/resources/archunit.properties
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,5 @@ freeze.store.default.allowStoreUpdate=true
#freeze.refreeze=true

freeze.store.default.path=archunit-violations

archRule.failOnEmptyShould = false
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ under the License.
<junit4.version>4.13.2</junit4.version>
<junit5.version>5.9.1</junit5.version>
<assertj.version>3.23.1</assertj.version>
<archunit.version>0.22.0</archunit.version>
<archunit.version>1.0.0</archunit.version>
<testcontainers.version>1.17.2</testcontainers.version>
<mockito.version>2.21.0</mockito.version>

Expand Down