[FLINK-30426] Set archRule.failOnEmptyShould = false to return old behavior

[snuyanzin]

In ArchUnit 1.0.0 there was added a breaking change [1]

As mentioned in Enhancements/Core ArchRules will now by default reject evaluating if the set passed to the should-clause is empty. This will break existing rules that don't check any elements in their should-clause. You can restore the old behavior by setting the ArchUnit property archRule.failOnEmptyShould=false

As a result all the rules which do no match anything will fail.
Also since Flink 1.17-SNAPSHOT depends on 1.0.0 ArchUnit, this version was updated to be synced

[1] https://github.com/TNG/ArchUnit/releases/tag/v0.23.0

[boring-cyborg]

Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)

[MartijnVisser]

@snuyanzin Thanks a lot. What I don't fully understand is the actual cause: was it because this repo depends on 1.17-SNAPSHOT, which meant that the flink-architecture-tests-production and flink-architecture-tests-test were built with Archunit 1.0.0?

[snuyanzin]

which meant that the flink-architecture-tests-production and flink-architecture-tests-test were built with Archunit 1.0.0?

yes, that's the reason

[MartijnVisser]

yes, that's the reason

Ugh. That's freakingly annoying.

[boring-cyborg]

Awesome work, congrats on your first merged pull request!