[FLINK-16260] Change generate-stackbrew-library.sh to support new release.metadata file #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ease.metadata file
zentol
requested changes
Jul 28, 2020
|
Thank you for your review. I addressed your comments. |
zentol
reviewed
Jul 28, 2020
| local repo="$1"; shift | ||
| local officialImagesUrl='https://github.com/docker-library/official-images/raw/master/library/' | ||
| # Inputs: | ||
| # - tags: comma-seprated list of image tags |
There was a problem hiding this comment.
variable name does not match (I'd use tags)
zentol
approved these changes
Jul 28, 2020
zentol
reviewed
Jul 28, 2020
| local key="$1" | ||
| local file="$2" | ||
| local line=$(cat $file | grep "$key:") | ||
| echo $line | cut -d ':' -f 2 | tr -d ' ' # remove key from line, remove whitespace |
There was a problem hiding this comment.
I looked at various entries in https://github.com/docker-library/official-images and they all separated tags with a comma and space , 😢
We could use sed again: echo $line | sed "s/${key}: //g"
|
Thank you for your thorough review! Merging ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final stackbrew file is identical (except for the order of the entries) with the old file.
Once this and #32 are merged, I'll open PRs to update the individual branches and master.