Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-16260] Add support for Java11 in dev-master / introduce new release.metadata file #32

Closed
wants to merge 7 commits into from
Closed

[FLINK-16260] Add support for Java11 in dev-master / introduce new release.metadata file #32

wants to merge 7 commits into from

Conversation

rmetzger
Copy link
Contributor

@rmetzger rmetzger commented Jul 27, 2020 •
edited
Loading

The Java11 docker image works.

@rmetzger rmetzger mentioned this pull request Jul 27, 2020
Closed
@rmetzger rmetzger changed the title Add support for Java11 in dev-master / introduce new release.metadata file [FLINK-16260] Add support for Java11 in dev-master / introduce new release.metadata file Jul 27, 2020
zentol
zentol requested changes Jul 28, 2020
View reviewed changes
generator.sh Outdated Show resolved Hide resolved
generator.sh Outdated Show resolved Hide resolved
generator.sh Outdated Show resolved Hide resolved
generator.sh Outdated Show resolved Hide resolved
zentol
zentol reviewed Jul 28, 2020
View reviewed changes
generator.sh Show resolved Hide resolved
@zentol zentol self-assigned this Jul 28, 2020
@rmetzger
Copy link
Contributor Author

Thanks a lot for your valuable feedback! I addressed all comments.

@rmetzger rmetzger force-pushed the dev-master-FLINK-16260-java11 branch from ceb46f5 to 4a1b98b Compare July 29, 2020 07:46
zentol
zentol requested changes Jul 29, 2020
View reviewed changes
add-version.sh Outdated Show resolved Hide resolved
generator.sh Outdated Show resolved Hide resolved
generator.sh Outdated Show resolved Hide resolved
generator.sh Outdated Show resolved Hide resolved
generator.sh Outdated Show resolved Hide resolved
@rmetzger @zentol
address PR comments
b7ccc16 
Co-authored-by: Chesnay Schepler <chesnay@apache.org>
@rmetzger rmetzger force-pushed the dev-master-FLINK-16260-java11 branch from 4c293da to b7ccc16 Compare July 29, 2020 11:34
@rmetzger
Copy link
Contributor Author

All items addressed.

@rmetzger
Copy link
Contributor Author

rmetzger commented Jul 29, 2020 •
edited
Loading

Note to self: There's one problem with this state:

Tags: 1.11.0-scala_2.11-java8, 1.11-scala_2.11-java8, scala_2.11-java8
Architectures: amd64
GitCommit: 4d0495116bfd4f18fe5932197bb5b6f1da90965c
Directory: ./1.11/scala_2.11-java8-debian

is missing the variants w/o -java8.

@rmetzger
Copy link
Contributor Author

The problem is resolved.

iemejia
iemejia reviewed Jul 29, 2020
View reviewed changes
add-custom.sh Outdated Show resolved Hide resolved
zentol
zentol reviewed Jul 29, 2020
View reviewed changes
testing/run_travis_tests.sh Outdated Show resolved Hide resolved
testing/run_travis_tests.sh Outdated Show resolved Hide resolved
zentol
zentol approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@zentol zentol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@rmetzger
Copy link
Contributor Author

Thanks! Merging ...

rmetzger added a commit that referenced this pull request Jul 30, 2020
@rmetzger
[FLINK-16260] Generate release.metadata file
1549175 
This closes #32
@rmetzger rmetzger closed this Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iemejia iemejia iemejia left review comments

@wangxiyuan wangxiyuan wangxiyuan left review comments

@zentol zentol zentol approved these changes

Assignees

@zentol zentol

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@rmetzger @iemejia @zentol @wangxiyuan