Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-21034] Refactor jemalloc switch to environment variable #57

Merged
merged 3 commits into from
Jan 20, 2021
Merged

[FLINK-21034] Refactor jemalloc switch to environment variable #57

merged 3 commits into from
Jan 20, 2021

Conversation

zentol
Copy link
Contributor

@zentol zentol commented Jan 19, 2021 •
edited
Loading

Spliced out of #54.

@zentol zentol mentioned this pull request Jan 20, 2021
Merged
wangyang0918
wangyang0918 reviewed Jan 20, 2021
View reviewed changes
Copy link

@wangyang0918 wangyang0918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the environment mechanism to disable jemalloc and just left some minor comments.

docker-entrypoint.sh Show resolved Hide resolved
docker-entrypoint.sh Outdated Show resolved Hide resolved
testing/bin/docker-entrypoint.sh Outdated Show resolved Hide resolved
Myasuka
Myasuka reviewed Jan 20, 2021
View reviewed changes
Copy link
Member

@Myasuka Myasuka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change of this, and I also create following ticket FLINK-21048.

testing/bin/config.sh Show resolved Hide resolved
@wangyang0918
Copy link

+1 for merging.

@zentol zentol merged commit 39685f4 into apache:dev-master Jan 20, 2021
@zentol zentol deleted the 21034 branch January 25, 2021 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Myasuka Myasuka Myasuka left review comments

@wangyang0918 wangyang0918 wangyang0918 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zentol @wangyang0918 @Myasuka