Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-16398] [kafka] Make Kafka ingress/egress type strings more compact #48

Closed
wants to merge 2 commits into from

Conversation

tzulitai
Copy link
Contributor

@tzulitai tzulitai commented Mar 4, 2020

I decided to go with the pattern:

  • Java ingress (egress): statefun.kafka.io/universal-ingress(egress)
  • Polygplot Protobuf ingress: statefun.kafka.io/protobuf-ingress
  • Polyglot generic egress: statefun.kafka.io/generic-egress

Basically, we mention "Kafka" in the namespace, to also match the artifact name org.apache.flink:statefun-kafka-io, and avoid mentioning "Kafka" over and over again in the type names.


mvn clean verify -Prun-e2e-tests passes locally

@tzulitai
Copy link
Contributor Author

tzulitai commented Mar 4, 2020

cc @igalshilman

@igalshilman
Copy link
Contributor

igalshilman commented Mar 4, 2020

Thanks @tzulitai, The short strings look good to me.
Can you also take a look at the docs?
basically grep of the root directory shouldn't mention the old strings anymore, if this is indeed the case then I'm +1 to merge.

@tzulitai
Copy link
Contributor Author

tzulitai commented Mar 4, 2020

@igalshilman yup, I did a check on that.

Thanks, will merge this!

@tzulitai tzulitai closed this in 11aceff Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants