[FLINK-23926] one timestamp #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpinegizmo
force-pushed
the
FLINK-23926-one-timestamp
branch
3 times, most recently
from
709a68f
to
5a3bfcf
Compare
alpinegizmo
force-pushed
the
FLINK-23926-one-timestamp
branch
from
5a3bfcf
to
aaffd3f
Compare
NicoK
requested changes
Sep 1, 2021
common/src/main/java/org/apache/flink/training/exercises/common/datatypes/TaxiRide.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/apache/flink/training/exercises/common/sources/TaxiRideGenerator.java
Outdated
Show resolved
Hide resolved
...lerts/src/solution/java/org/apache/flink/training/solutions/longrides/LongRidesSolution.java
Show resolved
Hide resolved
...lerts/src/solution/java/org/apache/flink/training/solutions/longrides/LongRidesSolution.java
Outdated
Show resolved
Hide resolved
...lerts/src/solution/java/org/apache/flink/training/solutions/longrides/LongRidesSolution.java
Outdated
Show resolved
Hide resolved
...c/solution/scala/org/apache/flink/training/solutions/longrides/scala/LongRidesSolution.scala
Outdated
Show resolved
Hide resolved
...de-alerts/src/test/java/org/apache/flink/training/exercises/longrides/LongRidesUnitTest.java
Outdated
Show resolved
Hide resolved
...de-alerts/src/test/java/org/apache/flink/training/exercises/longrides/LongRidesUnitTest.java
Outdated
Show resolved
Hide resolved
alpinegizmo
force-pushed
the
FLINK-23926-one-timestamp
branch
from
f1f945e
to
a7150df
Compare
NicoK
approved these changes
Sep 1, 2021
alpinegizmo
force-pushed
the
FLINK-23926-one-timestamp
branch
2 times, most recently
from
961be5d
to
a7deba1
Compare
NicoK
requested changes
Sep 2, 2021
alpinegizmo
force-pushed
the
FLINK-23926-one-timestamp
branch
from
a7deba1
to
395ee90
Compare
|
@NicoK I've reworked the DISCUSSION for the long-rides exercise again. It should be correct now. |
NicoK
approved these changes
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is layered on top of #31.
The objective is to replace the startTime and endTime fields with a single eventTime field. This is more natural, and will make it more straightforward to convert a
DataStream<TaxiRide>into a table.This does affect the long rides exercise. The biggest change is that it is no longer possible to determine if a ride has been too long in the case where the START event is missing.