Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-31174][doc] fix inconsistent data format between Learn-Flink Doc and flink-training-repo #22016

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ChenZhongPu
Copy link

Due to the previous pr in which the data format of TaxiRide is changed, there is an inconsistency in Data Pipelines & ETL. To be specific,

  • Since we cannot obtain startTime and endTime at the same time, I change the sample code to compute the (Euclidean) distance instead.
  • I also conducted the experiment using the updated code with parallelism 4 to get the new sample output.
  • Chinese translation is also updated.

Before:

 Interval rideInterval = new Interval(ride.startTime, ride.endTime);
 Minutes duration = rideInterval.toDuration().toStandardMinutes();
 out.collect(new Tuple2<>(ride.startCell, duration));

After:

double distance = ride.getEuclideanDistance(ride.startLon, ride.startLat);
out.collect(new Tuple2<>(ride.startCell, distance));

… and flink-training-repo

- Use distance instead of duration because we cannot obtain `startTime` and `endTime` at the same time.
- Chinese translation is also updated.

Signed-off-by: CHEN Zhongpu <chenloveit@gmail.com>
@ChenZhongPu ChenZhongPu changed the title [FLINK-3117][doc] fix inconsistent data format between Learn-Flink Doc and flink-training-repo [FLINK-31174][doc] fix inconsistent data format between Learn-Flink Doc and flink-training-repo Feb 24, 2023
@flinkbot
Copy link
Collaborator

flinkbot commented Feb 24, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants