Use TIMESTAMP instead of TO_TIMESTAMP to avoid the bug

apache · Jul 3, 2022 · 4780c64 · 4780c64
1 parent 59aef51
commit 4780c64
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/...dbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSourceITCase.java b/...dbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSourceITCase.java
@@ -316,10 +316,9 @@ public void testFilter() throws Exception {
         // test simple filter
         assertQueryReturns("SELECT * FROM FAKE_TABLE WHERE idx = 1", onlyRow1);
         // test TIMESTAMP filter
-        //        assertQueryReturns(
-        //                "SELECT * FROM FAKE_TABLE WHERE timestamp6_col = TO_TIMESTAMP('2020-01-01
-        // 15:35:00.123456')",
-        //                onlyRow1);
+        assertQueryReturns(
+                "SELECT * FROM FAKE_TABLE WHERE timestamp6_col = TIMESTAMP '2020-01-01 15:35:00.123456'",
+                onlyRow1);
         // test the IN operator
         assertQueryReturns(
                 "SELECT * FROM "

diff --git a/...bc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcFilterPushdownVisitorTest.java b/...bc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcFilterPushdownVisitorTest.java
@@ -50,6 +50,7 @@
 import java.sql.DriverManager;
 import java.sql.SQLException;
 import java.sql.Statement;
+import java.util.Arrays;
 import java.util.List;
 import java.util.Optional;
 import java.util.TimeZone;
@@ -131,7 +132,7 @@ public void clearOutputTable() throws Exception {
     @Test
     public void testSimpleExpressionPrimitiveType() {
         ResolvedSchema schema = tEnv.sqlQuery("SELECT * FROM " + INPUT_TABLE).getResolvedSchema();
-        List.of(
+        Arrays.asList(
                         "id = 6",
                         "id >= 6",
                         "id > 6",
@@ -247,6 +248,6 @@ private List<ResolvedExpression> resolveSQLFilterToExpression(
                                 })
                         .build();
 
-        return resolver.resolve(List.of(resolvedExp));
+        return resolver.resolve(Arrays.asList(resolvedExp));
     }
 }