-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-11767] Introduce new TypeSerializerUpgradeTestBase #10324
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 2bcdaed (Tue Nov 26 09:35:38 UTC 2019) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
Hi @tzulitai, LGTM 👍 |
…eSerializerUpgradeTestBase
… to base class Tests derived from this should use the list of migrations versions from the base class, to ensure that we always update all the tests in lockstep.
…vour of TypeSerializerUpgradeTestBase There are still a lot of tests that need to be ported, but we should not add new tests using the old test base.
This currently doesn't compile correctly because we use the wrong shaded ASM7 dependency. I fixed this and also added a couple more commits to add test support for Flink 1.8 and 1.9, once travis is green I'll merge this. |
2bcdaed
to
fdf0407
Compare
I pushed my changes to this PR so that you can have a look. cc @igalshilman |
I went over @aljoscha's recent changes, +1 to merge. |
What is the purpose of the change
This PR introduces
TypeSerializerUpgradeTestBase
to fully replaceTypeSerializerSnapshotMigrationTestBase
.The old test base needs to be replaced because it does not provide any means to generate test serializer snapshot files for each corresponding serializer. Before, what was written in the serializer snapshot test files and how they were written was not visible at all to developers, and also caused a lot of trouble when attempting to release new Flink versions and we have to generate new test files for the current version.
As part of this change, the PR introduces a utility class
ClassRelocator
.This utility allows us to relocate classes to a different name.
We require this in the serializer upgrade tests, because some test scenarios attempt to test schema upgrades, e.g. adding / removing fields from a Pojo class.
The
ClassRelocator
utility allows us to define two different versions of a Pojo class under the same name (one pre-upgrade that is used for writing the test serializer snapshot file, and the other after upgrade used for upgrade verification).Brief change log
ClassRelocator
TypeSerializerUpgradeTestBase
PojoSerializer
upgrade test based on the new test base.Verifying this change
PojoSerializerUpgradeTest
. It should work also in the IDE.Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation