Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-15629][runtime] Remove LegacyScheduler class and the consequently unused codes #10883

Closed
wants to merge 7 commits into from
Closed

[FLINK-15629][runtime] Remove LegacyScheduler class and the consequently unused codes #10883

wants to merge 7 commits into from

Conversation

zhuzhurk
Copy link
Contributor

@zhuzhurk zhuzhurk commented Jan 17, 2020 •
edited
Loading

What is the purpose of the change

This task is to remove the LegacyScheduler class and the consequently unused codes after this removal.
Note that the scheduling/failover logics in ExecutionGraph would be removed in a separate task.
This change is based on #10899 and #10858.

Brief change log

  • Removed LegacyScheduler and its factory and tests
  • Removed consequently unused codes

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 17, 2020 •
edited
Loading

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit dde0359 (Fri Oct 16 10:33:07 UTC 2020)

Warnings:

  • 1 pom.xml files were touched: Check for build and licensing issues.
  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 17, 2020 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@zhuzhurk zhuzhurk force-pushed the FLINK_15629_remove_LegacyScheduler branch 3 times, most recently from 13d3657 to ec48a6f Compare January 21, 2020 08:47
@zentol zentol added the post-1.10-scheduler-feedback PRs that should be delayed until we got some feedback on the new scheduler. label Jan 29, 2020
@zhuzhurk zhuzhurk force-pushed the FLINK_15629_remove_LegacyScheduler branch from ec48a6f to e9eb8ac Compare February 12, 2020 02:43
@tillrohrmann tillrohrmann self-assigned this May 15, 2020
tillrohrmann
tillrohrmann approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR @zhuzhurk. LGTM. I had a single comment which I will address myself while merging this PR.

flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultSchedulerTestUtils.java Outdated
private final JobGraph jobGraph;

private BackPressureStatsTracker backPressureStatsTracker = VoidBackPressureStatsTracker.INSTANCE;
private Executor ioExecutor = Executors.newSingleThreadExecutor();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would require the user to pass in an Executor for the ioExecutor because this forces him to properly clean it up after the test.

@tillrohrmann tillrohrmann force-pushed the FLINK_15629_remove_LegacyScheduler branch from e9eb8ac to dde0359 Compare May 15, 2020 16:14
@tillrohrmann
Copy link
Contributor

Failing test case seems to be unrelated. Merging this PR now.

@zhuzhurk
Copy link
Contributor Author

Thanks for reviewing, patching and merging these changes! @tillrohrmann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillrohrmann tillrohrmann tillrohrmann approved these changes

Assignees

@tillrohrmann tillrohrmann

Labels
component=Runtime/Coordination post-1.10-scheduler-feedback PRs that should be delayed until we got some feedback on the new scheduler. review=description?
Projects
None yet
Milestone
No milestone
5 participants
@zhuzhurk @flinkbot @tillrohrmann @rmetzger @zentol