Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-15668][tests] Remove travis test stages for legacy scheduler #10899

Conversation

zhuzhurk
Copy link
Contributor

What is the purpose of the change

AlsoRunWithLegacyScheduler is used to enable IT cases for legacy scheduler.
This task is to remove it as well as the related test stages from travis.

Brief change log

  • Removed AlsoRunWithLegacyScheduler
  • Removed test stages for legacy scheduler

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 19, 2020

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit ea341af (Fri Oct 16 10:32:56 UTC 2020)

Warnings:

  • 1 pom.xml files were touched: Check for build and licensing issues.
  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 19, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@zhuzhurk
Copy link
Contributor Author

@tillrohrmann @GJL would you help to review this change when you have time?

@zhuzhurk zhuzhurk force-pushed the FLINK_15668_remove_AlsoRunWithLegacyScheduler branch from edb45d1 to 658c41c Compare January 21, 2020 08:43
@tillrohrmann
Copy link
Contributor

Thanks for creating this PR @zhuzhurk. I talked to @GJL offline and we concluded that we would first like to release the new scheduler and gather a bit of feedback from users before we remove the legacy code. This effectively means that we will review and merge this PR in a bit and not right now.

@zentol zentol added the post-1.10-scheduler-feedback PRs that should be delayed until we got some feedback on the new scheduler. label Jan 29, 2020
@zhuzhurk zhuzhurk force-pushed the FLINK_15668_remove_AlsoRunWithLegacyScheduler branch from 658c41c to c3a2fd5 Compare February 12, 2020 01:17
@tillrohrmann tillrohrmann self-assigned this May 15, 2020
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR @zhuzhurk. LGTM. I will rebase and resolve the merge conflicts first. If AZP gives green light, then I will merge this PR.

@tillrohrmann tillrohrmann force-pushed the FLINK_15668_remove_AlsoRunWithLegacyScheduler branch from c3a2fd5 to ea341af Compare May 15, 2020 15:46
@tillrohrmann
Copy link
Contributor

Failing e2e test case is unrelated. Merging this PR now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component=Runtime/Coordination component=Tests post-1.10-scheduler-feedback PRs that should be delayed until we got some feedback on the new scheduler. review=description?
Projects
None yet
5 participants