[FLINK-16606][python] Throw exceptions for the data types which are not currently supported #11414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit ef1c121 (Mon Mar 16 08:17:02 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
dianfu
force-pushed
the
FLINK-16606
branch
2 times, most recently
from
ba28e3b
to
6223ae6
Compare
hequn8128
reviewed
Mar 17, 2020
Comment on lines
+1632
to
+1694
| elif isinstance(data_type, DecimalType): | ||
| if data_type.precision == 38 and data_type.scale == 18: | ||
| return Types.DECIMAL() | ||
| else: | ||
| raise TypeError("The precision must be 38 and the scale must be 18 for DecimalType, " | ||
| "got %s" % repr(data_type)) | ||
|
|
||
| # TimeType | ||
| elif isinstance(data_type, TimeType): | ||
| if data_type.precision == 0: | ||
| return Types.SQL_TIME() | ||
| else: | ||
| raise TypeError("The precision must be 0 for TimeType, got %s" % repr(data_type)) | ||
|
|
||
| # TimestampType | ||
| elif isinstance(data_type, TimestampType): | ||
| if data_type.precision == 3: | ||
| return Types.SQL_TIMESTAMP() | ||
| else: | ||
| raise TypeError("The precision must be 3 for TimestampType, got %s" % repr(data_type)) | ||
|
|
||
| # LocalZonedTimestampType | ||
| elif isinstance(data_type, LocalZonedTimestampType): | ||
| if data_type.precision == 3: | ||
| return gateway.jvm.org.apache.flink.api.common.typeinfo.Types.INSTANT | ||
| else: | ||
| raise TypeError("The precision must be 3 for LocalZonedTimestampType, got %s" | ||
| % repr(data_type)) | ||
|
|
||
| # VarCharType | ||
| elif isinstance(data_type, VarCharType): | ||
| if data_type.length == 0x7fffffff: | ||
| return Types.STRING() | ||
| else: | ||
| raise TypeError("The length limit must be 0x7fffffff(2147483647) for VarCharType, " | ||
| "got %s" % repr(data_type)) | ||
|
|
||
| # VarBinaryType | ||
| elif isinstance(data_type, VarBinaryType): | ||
| if data_type.length == 0x7fffffff: | ||
| return Types.PRIMITIVE_ARRAY(Types.BYTE()) | ||
| else: | ||
| raise TypeError("The length limit must be 0x7fffffff(2147483647) for VarBinaryType, " | ||
| "got %s" % repr(data_type)) | ||
|
|
||
| # YearMonthIntervalType | ||
| elif isinstance(data_type, YearMonthIntervalType): | ||
| return Types.INTERVAL_MONTHS() | ||
| if data_type.resolution == YearMonthIntervalType.YearMonthResolution.MONTH and \ | ||
| data_type.precision == 2: | ||
| return Types.INTERVAL_MONTHS() | ||
| else: | ||
| raise TypeError("The resolution must be YearMonthResolution.MONTH and the precision " | ||
| "must be 2 for YearMonthIntervalType, got %s" % repr(data_type)) | ||
|
|
||
| # DayTimeIntervalType | ||
| elif isinstance(data_type, DayTimeIntervalType): | ||
| return Types.INTERVAL_MILLIS() | ||
| if data_type.resolution == DayTimeIntervalType.DayTimeResolution.SECOND and \ | ||
| data_type.day_precision == 2 and data_type.fractional_precision == 3: | ||
| return Types.INTERVAL_MILLIS() | ||
| else: | ||
| raise TypeError("The resolution must be DayTimeResolution.SECOND, the day_precision " | ||
| "must be 2 and the fractional_precision must be 3 for " | ||
| "DayTimeIntervalType, got %s" % repr(data_type)) |
There was a problem hiding this comment.
Maybe also add python notice document in the related APIs?
…ot currently supported
|
@hequn8128 Thanks for the good suggestions. Have updated the PR. |
|
@dianfu Thanks a lot for the update. Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Currently, there are still cases where a data type isn't supported as the Python data type will be firstly converted to TypeInformation which will lose a few information, e.g,
SECONDand the fractionalPrecision could only be 3MONTHand theyearPrecisioncould only be 2We should throw exceptions for the cases not supported.
Brief change log
Verifying this change
This change is a trivial rework without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation