Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BP-1.10][FLINK-14316] Properly manage rpcConnection in JobManagerLeaderListener under leader change #11604

Closed
wants to merge 3 commits into from
Closed

[BP-1.10][FLINK-14316] Properly manage rpcConnection in JobManagerLeaderListener under leader change #11604

wants to merge 3 commits into from

Commits on Apr 1, 2020

  1. [FLINK-16373] Make JobManagerLeaderListener thread safe 

    The JobManagerLeaderListener used by the JobLeaderService was not thread safe. Stopping the listener
while notifying a new leader could lead to an IllegalStateException where the rpcConnection which
was supposed to be started was concurrently closed by the stop call.

This closes apache#11313.
    @tillrohrmann
    tillrohrmann committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    ec1055d View commit details
    Browse the repository at this point in the history

  2. [FLINK-16836] Clear rpcConnection field in JobManagerLeaderListener w… 

    …hen target loses leadership

Clearing the rpcConnection field in the JobManagerLeaderListener when target loses leadership
prevents that we try to reconnect to the target in case JobLeaderService.reconnect(JobID) is
called.

This closes apache#11552.
    @tillrohrmann
    tillrohrmann committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    c1bb02a View commit details
    Browse the repository at this point in the history

  3. [FLINK-14316] Properly manage rpcConnection in JobManagerLeaderListen… 

    …er under leader change

This commit changes how the rpcConnection is managed in JobManagerLeaderListener under leader change.
This component clears now the fields rpcConnection and currentJobMasterId if the leader loses leadership.
Moreover, it only restarts a connection attempt if the leader session id is new.
    @tillrohrmann
    tillrohrmann committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    7abc228 View commit details
    Browse the repository at this point in the history