[BP-1.10][FLINK-14316] Properly manage rpcConnection in JobManagerLeaderListener under leader change #11604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JobManagerLeaderListener used by the JobLeaderService was not thread safe. Stopping the listener while notifying a new leader could lead to an IllegalStateException where the rpcConnection which was supposed to be started was concurrently closed by the stop call. This closes apache#11313.
…hen target loses leadership Clearing the rpcConnection field in the JobManagerLeaderListener when target loses leadership prevents that we try to reconnect to the target in case JobLeaderService.reconnect(JobID) is called. This closes apache#11552.
…er under leader change This commit changes how the rpcConnection is managed in JobManagerLeaderListener under leader change. This component clears now the fields rpcConnection and currentJobMasterId if the leader loses leadership. Moreover, it only restarts a connection attempt if the leader session id is new.
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 7abc228 (Wed Apr 15 11:39:28 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
|
Merging this PR since the original PR has been approved. |
tillrohrmann
added a commit
that referenced
this pull request
Apr 2, 2020
…er under leader change This commit changes how the rpcConnection is managed in JobManagerLeaderListener under leader change. This component clears now the fields rpcConnection and currentJobMasterId if the leader loses leadership. Moreover, it only restarts a connection attempt if the leader session id is new. This closes #11604.
|
Merge manually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a backport of #11603, #11552 and #11313 onto
release-1.10.