-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-14267][connectors/filesystem]Introduce BaseRow Encoder in csv for filesystem table sink. #11629
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 5a3f35f (Fri Apr 03 14:23:39 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
@azagrebin thanks for update the PR link ^_^ |
@leonardBang no worries, I also created this kind of PR couple of times :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @leonardBang for contribution, left some comments.
flink-formats/flink-csv/src/main/java/org/apache/flink/formats/csv/CsvBaseRowEncoder.java
Outdated
Show resolved
Hide resolved
flink-formats/flink-csv/src/main/java/org/apache/flink/formats/csv/CsvBaseRowEncoder.java
Outdated
Show resolved
Hide resolved
flink-formats/flink-csv/src/main/java/org/apache/flink/formats/csv/CsvBaseRowEncoder.java
Outdated
Show resolved
Hide resolved
flink-formats/flink-csv/src/main/java/org/apache/flink/formats/csv/CsvBaseRowEncoder.java
Outdated
Show resolved
Hide resolved
flink-formats/flink-csv/src/main/java/org/apache/flink/formats/csv/CsvBaseRowEncoder.java
Outdated
Show resolved
Hide resolved
flink-formats/flink-csv/src/main/java/org/apache/flink/formats/csv/CsvBaseRowEncoder.java
Outdated
Show resolved
Hide resolved
flink-formats/flink-csv/src/main/java/org/apache/flink/formats/csv/CsvBaseRowEncoder.java
Outdated
Show resolved
Hide resolved
flink-formats/flink-csv/src/main/java/org/apache/flink/formats/csv/CsvBaseRowEncoder.java
Outdated
Show resolved
Hide resolved
flink-formats/flink-csv/src/main/java/org/apache/flink/formats/csv/CsvBaseRowEncoder.java
Outdated
Show resolved
Hide resolved
fe2c376
to
7a5b8de
Compare
…ith RowData (new table internal data structure)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is just a lambda function. You can merge this PR to FormatFactory PR.
flink-formats/flink-csv/src/main/java/org/apache/flink/formats/csv/CsvRowDataEncoder.java
Outdated
Show resolved
Hide resolved
flink-formats/flink-csv/src/main/java/org/apache/flink/formats/csv/CsvRowDataEncoder.java
Outdated
Show resolved
Hide resolved
flink-formats/flink-csv/src/main/java/org/apache/flink/formats/csv/CsvRowDataEncoder.java
Outdated
Show resolved
Hide resolved
merged in #11755 |
What is the purpose of the change
This pull request introduce BaseRow Csv Encoder in csv format for filesystem table sink..
Brief change log
Verifying this change
Add unit tests in CsvBaseRowDeSerializationTest.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation
This PR is just part of new feature
filesystemTableSink
and will add docs when the umbrella tasks finished.