Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-14267][connectors/filesystem]Introduce BaseRow Encoder in csv for filesystem table sink. #11629

Closed
wants to merge 2 commits into from

Conversation

leonardBang
Copy link
Contributor

What is the purpose of the change

This pull request introduce BaseRow Csv Encoder in csv format for filesystem table sink..

Brief change log

  • Introduce BaseRow Csv Encoder.
  • Reuse current CsvRowSerializationSchema to deal csv serialzation.

Verifying this change

Add unit tests in CsvBaseRowDeSerializationTest.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): ( no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (JavaDocs)
    This PR is just part of new feature filesystemTableSink and will add docs when the umbrella tasks finished.

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 3, 2020

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 5a3f35f (Fri Apr 03 14:23:39 UTC 2020)

Warnings:

  • 1 pom.xml files were touched: Check for build and licensing issues.
  • No documentation files were touched! Remember to keep the Flink docs up to date!
  • This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 3, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@azagrebin azagrebin changed the title [FLINK-16267][connectors/filesystem]Introduce BaseRow Encoder in csv for filesystem table sink. [FLINK-14267][connectors/filesystem]Introduce BaseRow Encoder in csv for filesystem table sink. Apr 3, 2020
@leonardBang
Copy link
Contributor Author

@azagrebin thanks for update the PR link ^_^

@azagrebin
Copy link
Contributor

@leonardBang no worries, I also created this kind of PR couple of times :)

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @leonardBang for contribution, left some comments.

…ith RowData (new table internal data structure)
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is just a lambda function. You can merge this PR to FormatFactory PR.

@leonardBang
Copy link
Contributor Author

merged in #11755

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants