-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-14257][Connectors / FileSystem]Integrate csv to FileSystemTableFactory #11755
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 6eda10e (Wed Apr 15 12:50:38 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @leonardBang , we may need wait applying RowData
to blink planner. left some comments.
...-formats/flink-csv/src/test/java/org/apache/flink/formats/csv/BaseRowCsvInputformatTest.java
Outdated
Show resolved
Hide resolved
...formats/flink-csv/src/test/java/org/apache/flink/formats/csv/BaseRowCsvFilesystemITCase.java
Outdated
Show resolved
Hide resolved
...mats/flink-csv/src/test/java/org/apache/flink/formats/csv/BaseRowCsvDeSerializationTest.java
Outdated
Show resolved
Hide resolved
flink-formats/flink-csv/src/main/java/org/apache/flink/formats/csv/BaseRowCsvInputformat.java
Outdated
Show resolved
Hide resolved
dff5cdb
to
4be08fc
Compare
.../flink-csv/src/main/java/org/apache/flink/formats/csv/CsvRowDataFileSystemFormatFactory.java
Outdated
Show resolved
Hide resolved
.../flink-csv/src/main/java/org/apache/flink/formats/csv/CsvRowDataFileSystemFormatFactory.java
Outdated
Show resolved
Hide resolved
.../flink-csv/src/main/java/org/apache/flink/formats/csv/CsvRowDataFileSystemFormatFactory.java
Outdated
Show resolved
Hide resolved
.../flink-csv/src/main/java/org/apache/flink/formats/csv/CsvRowDataFileSystemFormatFactory.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me overall, please make tests passing.
.../flink-csv/src/main/java/org/apache/flink/formats/csv/CsvRowDataFileSystemFormatFactory.java
Outdated
Show resolved
Hide resolved
.../flink-csv/src/main/java/org/apache/flink/formats/csv/CsvRowDataFileSystemFormatFactory.java
Outdated
Show resolved
Hide resolved
...ts/flink-csv/src/test/java/org/apache/flink/formats/csv/CsvRowDataFilesystemBatchITCase.java
Outdated
Show resolved
Hide resolved
...ts/flink-csv/src/test/java/org/apache/flink/formats/csv/CsvRowDataFilesystemBatchITCase.java
Outdated
Show resolved
Hide resolved
...ts/flink-csv/src/test/java/org/apache/flink/formats/csv/CsvRowDataFilesystemBatchITCase.java
Outdated
Show resolved
Hide resolved
...s/flink-csv/src/test/java/org/apache/flink/formats/csv/CsvRowDataFilesystemStreamITCase.java
Outdated
Show resolved
Hide resolved
@flinkbot run azure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 Thanks for updating.
What is the purpose of the change
This pull request Integrates csv format to FileSystemTableFactory.
Brief change log
BaseRowCsvInputformat
BaseRowCsvFileSystemFormatFactory
Verifying this change
Add
BaseRowCsvFilesystemITCase
and unit tests in formatsDoes this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation