Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-15817][k8s] Clean up residual resources when failed to deploy a Flink cluster #11672

Closed
wants to merge 1 commit into from

Conversation

zhengcanbin
Copy link
Contributor

@zhengcanbin zhengcanbin commented Apr 8, 2020

What is the purpose of the change

Clean up all the residual resources when failed to deploy a new Flink cluster.

Brief change log

  • Invoke KubernetesClient#stopAndCleanupCluster in the exception handling block of KubernetesClusterDescriptor#deployClusterInternal.

Verifying this change

This change is a trivial work on exception handling improvement, it can be manually verified as follows:
Try to deploy a new Flink cluster with the following parameters:
./bin/kubernetes-session.sh -Dkubernetes.cluster-id=x5rvvn9fltbxi3l2c5piwlwxlyn0yji766afathqokvyttsq5yhtsbsyromrcz -Dkubernetes.container.image=flink:latest -Djobmanager.heap.size=1024m -Dtaskmanager.memory.process.size=1024m -Dkubernetes.jobmanager.service-account=flink;
as expected, an exception will be thrown since the name of the rest Service has more than 63 characters, one can confirm that all the related k8s resources have been cleaned up after the submission terminates.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 8, 2020

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit f1faad8 (Wed Apr 08 13:54:36 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 8, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@zhengcanbin
Copy link
Contributor Author

@flinkbot run travis

@zhengcanbin
Copy link
Contributor Author

cc @tillrohrmann. Could you help take a look at this PR? It's a trivial improvement.

@tillrohrmann tillrohrmann self-assigned this Apr 9, 2020
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR @zhengcanbin. LGTM. Merging this PR now.

tillrohrmann pushed a commit that referenced this pull request Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants