[FLINK-15817][k8s] Clean up residual resources when failed to deploy a Flink cluster #11672
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Clean up all the residual resources when failed to deploy a new Flink cluster.
Brief change log
KubernetesClient#stopAndCleanupCluster
in the exception handling block ofKubernetesClusterDescriptor#deployClusterInternal
.Verifying this change
This change is a trivial work on exception handling improvement, it can be manually verified as follows:
Try to deploy a new Flink cluster with the following parameters:
./bin/kubernetes-session.sh -Dkubernetes.cluster-id=x5rvvn9fltbxi3l2c5piwlwxlyn0yji766afathqokvyttsq5yhtsbsyromrcz -Dkubernetes.container.image=flink:latest -Djobmanager.heap.size=1024m -Dtaskmanager.memory.process.size=1024m -Dkubernetes.jobmanager.service-account=flink
;as expected, an exception will be thrown since the name of the rest Service has more than 63 characters, one can confirm that all the related k8s resources have been cleaned up after the submission terminates.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation