Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-14258][table][filesystem] Integrate file system connector to streaming sink #11796

Merged
merged 2 commits into from
Apr 26, 2020

Conversation

JingsongLi
Copy link
Contributor

What is the purpose of the change

Integrate file system connector to streaming sink.

Brief change log

  • Integrate streaming file sink in FileSystemTableSink
  • Add ROLLING_POLICYs

Verifying this change

  • FsStreamingSinkCsvITCaseBase
  • ParquetFsStreamingSinkITCase

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: (no
  • The runtime per-record code paths (performance sensitive): (no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no
  • The S3 file system connector: (no

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? JavaDocs

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 90fa0d2 (Fri Apr 17 13:33:53 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 17, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @JingsongLi for the contribution, generally LGTM, left some minor comments.


/**
* Table {@link RollingPolicy}, now it is a {@link CheckpointRollingPolicy}.
* Because partition commit is hard to support false.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This note looks like strange, I cannot the meaning..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for out of date comments, should be:

Table {@link RollingPolicy}, it extends {@link CheckpointRollingPolicy} for bulk writers.

@@ -88,7 +88,9 @@ public static String generatePartitionPath(LinkedHashMap<String, String> partiti
suffixBuf.append(escapePathName(e.getValue()));
i++;
}
suffixBuf.append(Path.SEPARATOR);
if (partitionSpec.size() > 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can move the judgement to the begin to make the code path short

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

if (partitionSpec.isEmpty()) {
  return "";
}

@JingsongLi
Copy link
Contributor Author

Thanks @leonardBang for the review, merging...

@JingsongLi JingsongLi merged commit f095f26 into apache:master Apr 26, 2020
@JingsongLi JingsongLi deleted the streamPureFilesystem branch April 26, 2020 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants