-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-14258][table][filesystem] Integrate file system connector to streaming sink #11796
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 90fa0d2 (Fri Apr 17 13:33:53 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
90fa0d2
to
4d98d46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @JingsongLi for the contribution, generally LGTM, left some minor comments.
...table-runtime-blink/src/main/java/org/apache/flink/table/filesystem/FileSystemTableSink.java
Show resolved
Hide resolved
...table-runtime-blink/src/main/java/org/apache/flink/table/filesystem/FileSystemTableSink.java
Show resolved
Hide resolved
...table-runtime-blink/src/main/java/org/apache/flink/table/filesystem/FileSystemTableSink.java
Show resolved
Hide resolved
|
||
/** | ||
* Table {@link RollingPolicy}, now it is a {@link CheckpointRollingPolicy}. | ||
* Because partition commit is hard to support false. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This note looks like strange, I cannot the meaning..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for out of date comments, should be:
Table {@link RollingPolicy}, it extends {@link CheckpointRollingPolicy} for bulk writers.
@@ -88,7 +88,9 @@ public static String generatePartitionPath(LinkedHashMap<String, String> partiti | |||
suffixBuf.append(escapePathName(e.getValue())); | |||
i++; | |||
} | |||
suffixBuf.append(Path.SEPARATOR); | |||
if (partitionSpec.size() > 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can move the judgement to the begin to make the code path short
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch.
if (partitionSpec.isEmpty()) {
return "";
}
Thanks @leonardBang for the review, merging... |
What is the purpose of the change
Integrate file system connector to streaming sink.
Brief change log
FileSystemTableSink
ROLLING_POLICY
sVerifying this change
FsStreamingSinkCsvITCaseBase
ParquetFsStreamingSinkITCase
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation