[FLINK-17267] [table] legacy planner supports explain insert operation and introduce TableEnvironment#explainSql/Introduce TableEnvironment#explainSql api api #11905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit af67911 (Fri Apr 24 15:16:35 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
godfreyhe
force-pushed
the
FLINK-17267
branch
4 times, most recently
from
0774d4c
to
7050007
Compare
|
cc @danny0405 |
KurtYoung
reviewed
Apr 29, 2020
flink-python/pyflink/table/table.py
Outdated
Comment on lines
699
to
700
| Returns the AST of this table and the execution plan to compute | ||
| the result of this table. |
There was a problem hiding this comment.
delete to compute the result of this table.?
| @@ -466,6 +466,23 @@ def explain(self, table=None, extended=False): | |||
| else: | |||
| return self._j_tenv.explain(table._j_table, extended) | |||
|
|
|||
| def explain_sql(self, stmt, *extra_details): | |||
| """ | |||
| Returns the AST of the specified statement and the execution plan to compute | |||
| * The changelog traits produced by a physical rel node. | ||
| * e.g. GroupAggregate(..., changelogMode=[I,UA,D]) | ||
| */ | ||
| CHANGELOG_TRAITS |
There was a problem hiding this comment.
how about CHANGELOG_MODE? Traits is hard to understand for users.
| * @param operations The operations to be executed. | ||
| * @return the affected row counts (-1 means unknown). | ||
| */ | ||
| String explain(List<Operation> operations, ExplainDetail... extraDetails); |
There was a problem hiding this comment.
Rename this to explainInternal? When browsing TableEnvironmentImpl's code, it's hard to find out whether the public method is for public api or implementing some internal methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
For TableEnvironment#explain() method, legacy batch planner throws exception directly and legacy stream planner does not handle sink node. This pr fixes them problems first. And then, this pr aim to supports the following features: TableEnvironment#explainSql supports EXPLAIN statement; Introduce TableEnvironment#explainSql api, Introduce Table#explain api
Brief change log
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation