-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-16210][docs] Extending the "Flink Architecture" section. #12057
Conversation
…rmation about Flink Master components and application execution.
Pinging @aljoscha and @alpinegizmo (who had this rework in mind as well). |
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 41c4429 (Fri Oct 16 10:54:29 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
…t of Master and Worker section
Thanks a lot for working on this! I pushed two commits with suggestions. Another (slightly more complicated) thing is that the rest of the documentation changed and some of the links in this are now outdated. If you could rebase this and change the links that use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty happy with the page as a whole. It covers a coherent set of topics in a helpful way, and connects to the other parts of the documentation that need to be understood alongside this.
Here and there I found some small grammatical issues. And there are a few points where I think other changes are needed. I've provided suggestions in most cases.
Thanks for reviewing, @aljoscha and @alpinegizmo! It's weird that the links worked fine in the local build even with the duplicated reference to the base URL — I've corrected that and will also update the Documentation Style Guide. |
Thanks again, @morsapaes! I merged this. |
What is the purpose of the change
This PR extends the "Flink Architecture" section of the docs with more information about Flink Master components and application execution (incl. the new Application Cluster mode).
Brief change log
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation