[FLINK-17376][API/DataStream]Deprecated methods and related code updated #12189

mghildiy · 2020-05-16T11:38:14Z

What is the purpose of the change

Objective of this PR is to remove the following deprecated method and update related code:

RuntimeContext.getFoldingState(...)
OperatorStateStore.getSerializableListState(...)
OperatorStateStore.getOperatorState(...)

Brief change log

NA

Verifying this change

NA

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

flinkbot · 2020-05-16T11:41:49Z

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 256cc76 (Sat May 16 11:41:48 UTC 2020)

Warnings:

No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

❓ 1. The [description] looks good.
❓ 2. There is [consensus] that the contribution should go into to Flink.
❓ 3. Needs [attention] from.
❓ 4. The change fits into the overall [architecture].
❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

@flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
@flinkbot approve all to approve all aspects
@flinkbot approve-until architecture to approve everything until architecture
@flinkbot attention @username1 [@username2 ..] to require somebody's attention
@flinkbot disapprove architecture to remove an approval you gave earlier

flinkbot · 2020-05-16T12:04:00Z

CI report:

a3afaaf Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

@flinkbot run travis re-run the last Travis build
@flinkbot run azure re-run the last Azure build

aljoscha · 2020-05-18T11:58:32Z

...lesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java

@@ -388,7 +389,7 @@ public void initializeState(FunctionInitializationContext context) throws Except
 		}

 		OperatorStateStore stateStore = context.getOperatorStateStore();
-		restoredBucketStates = stateStore.getSerializableListState("bucket-states");
+		this.restoredBucketStates = stateStore.getListState(new ListStateDescriptor("bucket-states", State.class));


This will not actually work because getListState(..., State.class) should be created a GenericTypeInfo, which is incompatible with the JavaSerializer used before internally here.

aljoscha · 2020-05-18T11:59:04Z

@flinkbot run azure

dawidwys · 2020-05-20T15:20:29Z

Hey @mghildiy do you still want to work on this issue? This issue actually blocks the 1.11 release. I see you haven't addressed @aljoscha's comment yet. It's fine, but if you don't have time, maybe somebody else could take over.

mghildiy · 2020-05-21T02:22:32Z

Sorry for delay. I am stuck with some issues, and plan to work on it this weekend. If its needed urgently, I am fine with someone else taking it up.

klion26

@mghildiy thanks for the contribution. It seems there still some other FoldingState usages are not touched in current change.

flink-runtime/src/main/java/org/apache/flink/runtime/state/DefaultOperatorStateBackend.java

We do this because we want to deprecate that method. We will have to get rid of using JavaSerialization completely soon, though.

aljoscha · 2020-05-28T13:19:41Z

I rebased and fixed the problems, @klion26 would you take another look?

cc @mghildiy

klion26 · 2020-05-28T15:19:16Z

@aljoscha Will check it now

klion26

There are still some places contain folding state, such as TtlFoldingStateVerifier, TestSharedBuffer, KeyedStateStore, DefaultKeyedStateStore, WindowOperator, WindowOperatorContractTest.
and we need to update the doc state.md and state.zh.md

aljoscha · 2020-05-29T07:06:26Z

@klion26 That's a good point. This PR/Jira issue is about removing the access methods, we can remove FoldingState and the internals in the state backend later.

Good point about updating the docs! I will do that

This code was using the deprecated getSerializedListState(), which we want to remove.

aljoscha · 2020-05-29T08:55:52Z

@klion26 I pushed some more changes. Please take another look.

klion26 · 2020-05-29T09:41:14Z

@aljoscha thanks for the update. Remove FoldingState and the internals in the state backend later make senses to me. current PR LGTM % FoldingState in section Using Keyed State state.md & state.zh.md

diff for state.zh.md based on current pr
state.zh.md.diff.txt

aljoscha · 2020-06-02T11:10:36Z

pushed changes

klion26

@aljoscha thanks for the work. LGTM now

aljoscha · 2020-06-03T13:07:22Z

I've merged this on master and will also merge on release-1.11.

Thanks @mghildiy for the initial work, and thanks @klion26 for reviewing!

fapaul · 2020-06-17T11:16:00Z

It is probably worthwhile mentioning the transitive effect of these changes in the release notes.
For example, user jars that include the flink-connector-kafka dependency based on 1.10 will not work anymore due to the removal of OperatorStateStore.getSerializableListState.

aljoscha · 2020-06-17T14:25:26Z

That's a very good point! I'm adding a release note.

rmetzger added the review=description? label May 16, 2020

rmetzger added the component=API/DataStream label May 16, 2020

aljoscha reviewed May 18, 2020

View reviewed changes

klion26 reviewed May 21, 2020

View reviewed changes

flink-runtime/src/main/java/org/apache/flink/runtime/state/DefaultOperatorStateBackend.java Show resolved Hide resolved

aljoscha self-assigned this May 22, 2020

[FLINK-17376] Use JavaSerializer instead of getSerializableListState()

06d91b3

We do this because we want to deprecate that method. We will have to get rid of using JavaSerialization completely soon, though.

klion26 reviewed May 28, 2020

View reviewed changes

aljoscha and others added 3 commits May 29, 2020 10:54

[FLINK-17376] Don't restore from Flink <= 1.2 state in Kafka connector

ca105f1

This code was using the deprecated getSerializedListState(), which we want to remove.

[FLINK-17376] Remove deprecated state access methods

6c40c14

[FLINK-18032] Remove outdated sections in migration guide

6ec41f2

fixup! folding state removed from state.md

a3afaaf

klion26 approved these changes Jun 2, 2020

View reviewed changes

aljoscha closed this Jun 3, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FLINK-17376][API/DataStream]Deprecated methods and related code updated #12189

[FLINK-17376][API/DataStream]Deprecated methods and related code updated #12189

mghildiy commented May 16, 2020 •

edited

Loading

flinkbot commented May 16, 2020

flinkbot commented May 16, 2020 •

edited

Loading

aljoscha May 18, 2020

aljoscha commented May 18, 2020

dawidwys commented May 20, 2020

mghildiy commented May 21, 2020

klion26 left a comment

aljoscha commented May 28, 2020

klion26 commented May 28, 2020

klion26 left a comment

aljoscha commented May 29, 2020

aljoscha commented May 29, 2020

klion26 commented May 29, 2020 •

edited

Loading

aljoscha commented Jun 2, 2020

klion26 left a comment

aljoscha commented Jun 3, 2020

fapaul commented Jun 17, 2020

aljoscha commented Jun 17, 2020

[FLINK-17376][API/DataStream]Deprecated methods and related code updated #12189

[FLINK-17376][API/DataStream]Deprecated methods and related code updated #12189

Conversation

mghildiy commented May 16, 2020 • edited Loading

What is the purpose of the change

Brief change log

Verifying this change

Does this pull request potentially affect one of the following parts:

Documentation

flinkbot commented May 16, 2020

Automated Checks

Review Progress

flinkbot commented May 16, 2020 • edited Loading

CI report:

aljoscha May 18, 2020

Choose a reason for hiding this comment

aljoscha commented May 18, 2020

dawidwys commented May 20, 2020

mghildiy commented May 21, 2020

klion26 left a comment

Choose a reason for hiding this comment

aljoscha commented May 28, 2020

klion26 commented May 28, 2020

klion26 left a comment

Choose a reason for hiding this comment

aljoscha commented May 29, 2020

aljoscha commented May 29, 2020

klion26 commented May 29, 2020 • edited Loading

aljoscha commented Jun 2, 2020

klion26 left a comment

Choose a reason for hiding this comment

aljoscha commented Jun 3, 2020

fapaul commented Jun 17, 2020

aljoscha commented Jun 17, 2020

mghildiy commented May 16, 2020 •

edited

Loading

flinkbot commented May 16, 2020 •

edited

Loading

klion26 commented May 29, 2020 •

edited

Loading