New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-18377] Rename "Flink Master" back to JobManager in documentation #12723
Conversation
Building the docs with Ruby 2.7 and Jekyll 4.0.0 spits out a lot of warnings, see jekyll/jekyll#7947. Updating to 4.0.1 fixes this.
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit e090f55 (Fri Jun 19 12:50:40 UTC 2020) ✅no warnings Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe do another sweep for "Masters"
Co-authored-by: Chesnay Schepler <chesnay@apache.org>
Co-authored-by: Chesnay Schepler <chesnay@apache.org>
Co-authored-by: Chesnay Schepler <chesnay@apache.org>
Co-authored-by: Chesnay Schepler <chesnay@apache.org>
I pushed changes, PTAL. Also, thanks for the speedy review! |
Before, we used JobManager/Flink Workers, not we use JobManager/TaskManagers for the section titles.
For the latest commits: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Thanks for the reviews! I merged. Btw, I thought about adding release notes but we didn't announce the earlier renaming and the documentation was in enough of a mixed state that I would do this silently. |
What is the purpose of the change
Please see https://issues.apache.org/jira/browse/FLINK-18377 for a full description. The gist of it is that we want to get rid of the word "master".
Brief change log
glossary.md
/glossary.zh.md
to update definition ofJobManager
andJobMaster
mem_setup_master.md
tomem_setup_jobmanager.md
(same for.zh
). I didn't create redirects for this because the file was newly added for Flink 1.11{% link ...
syntax, this should help catch dead links betterThere is still an entry for
JobMaster
in the glossary. I could remove that one as well. The only mentions of master in the doc are now for theJobMaster
.Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation
It's a pure documentation change.