Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-17075][coordination] Reconcile deployed Executions #12815

Merged
merged 4 commits into from
Jul 8, 2020

Conversation

zentol
Copy link
Contributor

@zentol zentol commented Jul 3, 2020

With this PR the JobMaster can detect and reconcile deployments that are missing or unknown.

The TaskExecutor is periodically informing the JobMaster about the set of deployed executions, submitted with the heartbeat.

The Scheduler tracks the set of expected deployments with a new ExecutionDeploymentTracker component. The tracker is updated of deployed/terminated deployments by 2 new listeners in the ExecutionGraph.

The JobMaster reconciles deployments with a new ExecutionDeploymentReconciler component.

If the TaskExecutor is hosting an unexpected execution, then that execution will be canceled.
If the TaskExecutor is unexpectedly not hosting an execution, then the execution is failed in the ExecutionGraph.

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 3, 2020

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit c7057fb (Fri Jul 03 08:18:15 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 3, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@tillrohrmann tillrohrmann self-assigned this Jul 3, 2020
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR @zentol. The changes look already good. I had a couple of minor comments. Please take a look.

@tillrohrmann
Copy link
Contributor

Please also make sure that the failed e2e has not failed because of these changes.

Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments. I had one minor comment. This means the only thing which is left to decide is the interface of the ExecutionDeploymentReconciliationHandler. Concretely whether we want to encourage a call per Execution or also support batched calls.

@zentol zentol merged commit 2210aff into apache:master Jul 8, 2020
@zentol zentol deleted the 17075 branch December 8, 2021 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants