Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/flink 18661 efo de registration #13002

Closed
wants to merge 21 commits into from
Closed

Feature/flink 18661 efo de registration #13002

wants to merge 21 commits into from

Conversation

xiaolong-sn
Copy link
Contributor

What is the purpose of the change

This is the milestone of FLIP-128 to add EFO support to the FlinkKinesisConsumer.
The de-/regisiterStream operations has been introduce.

JIRA issue

Note

This PR is blocked by:

Brief change log

  • ConsumerConstants
    • Add the describe stream and descrbie stream consumer operation parameters.
  • KinesisConfigUtil
    • Add the validation of the above parameter
  • FanOutStreamInfo
    • Add a new data class for storing enhanced fan-out consumer info.
  • FlinkDataFetcher
    • Add a KinesisProxyV2Interface in order to register stream consumers when the efo registration mode is set to eager.
  • ShardConsumer
    • Add a KinesisProxyV2Interface in order to de-/register stream consumers when the efo registration mode is set to lazy.
  • KinesisProxyV2Interface & KinesisProxyV2
    • Add the de-/register stream consumer operations here.
  • AwsV2Util
    • Add several methods to classify exceptions.

Verifying this change

This change added tests and can be verified as follows:

  • KinesisProxyV2Test
  • AwsV2UtilTest

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

dannycranmer and others added 21 commits July 8, 2020 09:07
…ctoring ShardConsumer to use PollingRecordPublisher
[FLINK-18661][kinesis] Stream consumer Registration/Deregistration.
…-efo-4-configuration

# Conflicts:
#	flink-connectors/flink-connector-kinesis/pom.xml
#	flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
#	flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
#	flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxyV2.java
#	flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxyV2Interface.java
#	flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/AwsV2Util.java
#	flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/util/AwsV2UtilTest.java
@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 112bc7c (Tue Jul 28 02:44:17 UTC 2020)

Warnings:

  • 1 pom.xml files were touched: Check for build and licensing issues.
  • No documentation files were touched! Remember to keep the Flink docs up to date!
  • Invalid pull request title: No valid Jira ID provided

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 28, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants