New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-18483][kinesis] Test coverage improvements for FlinkKinesisConsumer/ShardConsumer #12850
[FLINK-18483][kinesis] Test coverage improvements for FlinkKinesisConsumer/ShardConsumer #12850
Conversation
…sumer/ShardConsumer
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit d2297eb (Wed Jul 08 08:26:59 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR LGTM.
I have checked and tested each test cases and they met requirements.
@flinkbot run azure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the improvements to the tests @dannycranmer.
Overall, I would like to eventually remove the use of mocking in the tests, but as it is the PR is already an improvement.
+1
...src/test/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumerTest.java
Outdated
Show resolved
Hide resolved
Merging this now ... |
…sumer/ShardConsumer This closes apache#12850.
What is the purpose of the change
Improved test coverage for existing
FlinkKinesisConsumer
polling consumption implementation (ShardConsumer
).Brief change log
ShardIteratorType
for existingShardConsumerTest
methodsShardConsumerTest
had high duplication, this has been extracted to a methodNote: Source code has not be modified, only test code.
Verifying this change
This change added tests and can be verified as follows:
flink/flink-connectors/flink-connector-kinesis
, specifically:--
ShardConsumerTest
Does this pull request potentially affect one of the following parts:
-- I have added a test scoped dependency on amazon-kinesis-aggregator to perform record aggregation
-- License: Apache 2.0
@Public(Evolving)
: noDocumentation