-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/flink 18661 efo de registration #13005
Feature/flink 18661 efo de registration #13005
Conversation
…sumer/ShardConsumer
…ctoring ShardConsumer to use PollingRecordPublisher
…LINK-18512-efo-2-record-publisher
…' into feature/FLINK-18483-efo-1-test-coverage
…83-efo-1-test-coverage
…anced fan-out consumers.
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit bf29035 (Tue Jul 28 12:03:09 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some things need moving and a few tweaks to the semantics of the methods
...rc/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
Outdated
Show resolved
Hide resolved
...sis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
Show resolved
Hide resolved
...sis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
Outdated
Show resolved
Hide resolved
...inesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxyV2.java
Outdated
Show resolved
Hide resolved
...inesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxyV2.java
Outdated
Show resolved
Hide resolved
...inesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxyV2.java
Outdated
Show resolved
Hide resolved
* {@inheritDoc} | ||
*/ | ||
@Override | ||
public void deregisterStreamConsumer(List<FanOutStreamInfo> fanOutStreamInfos) throws InterruptedException, ExecutionException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xiaolong-sn again please make this singular (single deregistration at a time)
Also this needs to open with describe and stagger too as per the FLIP flow chart to deal with competing requests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About deregisterStreamConsumer
operation, why can’t we simply deregister first, and if the exception it throws is ResourceNotFoundException
, we then simply end the operation ( for it indicates that the consumer is already deregistered by others).
That way, we do not have to call the describeStreamConsumer
operation at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the behavior and interface.
...ctor-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/AwsV2Util.java
Outdated
Show resolved
Hide resolved
… consumers to fit in the requirements of FLIP-128.
…nesisConsumer and KinesisDataFetcher.
@xiaolong-sn can you please rename this PR inline with the contribution guide? |
What is the purpose of the change
This is the milestone of FLIP-128 to add EFO support to the FlinkKinesisConsumer.
The de-/regisiterStream operations has been introduce.
JIRA issue
Note
This PR is blocked by:
Brief change log
ConsumerConstants
KinesisConfigUtil
FanOutStreamInfo
FlinkDataFetcher
ShardConsumer
KinesisProxyV2Interface
&KinesisProxyV2
AwsV2Util
Verifying this change
This change added tests and can be verified as follows:
KinesisProxyV2Test
AwsV2UtilTest
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation