[FLINK-18847][docs][python] Add documentation about data types in Python Table API #13084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 8e32bc6 (Fri Aug 07 07:34:07 UTC 2020) ✅no warnings Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
WeiZhong94
approved these changes
Aug 10, 2020
There was a problem hiding this comment.
Thanks for your PR @dianfu. LGTM overall, just minor comments.
|
|
||
| A list of all pre-defined data types can be found [below]({{ site.baseurl }}/dev/table/types.html#list-of-data-types). | ||
|
|
||
| Data Type and Python type mapping |
There was a problem hiding this comment.
Capitalize the first letter?
There was a problem hiding this comment.
type mapping -> Type Mapping ?
| DataTypes.DECIMAL(p, s) | ||
| {% endhighlight %} | ||
|
|
||
| <span class="label label-danger">注意</span> 当前，声明`DataTypes.DECIMAL(p, s)`中的所指定的精度 `p` 必须为38，尾数 `n` 必须为 `18`。 |
| DataTypes.TIME(p) | ||
| {% endhighlight %} | ||
|
|
||
| <span class="label label-danger">注意</span> 当前，声明`DataTypes.TIME(p)`中的所指定的精度 `p` 必须为0。 |
| DataTypes.TIMESTAMP(p) | ||
| {% endhighlight %} | ||
|
|
||
| <span class="label label-danger">注意</span> 当前，声明`DataTypes.TIMESTAMP(p)`中的所指定的精度 `p` 必须为3。 |
|
@WeiZhong94 Thanks for the review. Will fix the comments when merging the PR. |
dianfu
added a commit
that referenced
this pull request
Aug 10, 2020
…hon Table API This closes #13084.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request add documentation about data types in Python Table API
Brief change log
Verifying this change
This change is a documentation rework without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation