-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-19110][docs][python] Flatten current PyFlink documentation structure. #13302
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit f034b22 (Wed Sep 02 07:08:32 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WeiZhong94 Thanks for the PR. LGTM overall. Have left only one comments.
docs/dev/python/index.md
Outdated
@@ -2,7 +2,7 @@ | |||
title: "Python API" | |||
nav-id: python | |||
nav-parent_id: dev | |||
nav-pos: 50 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change this? This changes moves Python API
page between DataStream API
page and DataSet API
page. Is this intended?
@dianfu Thanks for your review! I have fixed the order of the documents. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WeiZhong94 Thanks for the update. LGTM.
+1 to merge. |
@flinkbot approve all |
@sunjincheng121 Thanks for the remind. Merging... |
What is the purpose of the change
This pull request flattens the current PyFlink documentation structure.
Brief change log
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation