[FLINK-3067] Use curator for committing offsets to ZK from Kafka #1451
Conversation
| @@ -632,6 +632,7 @@ public void run() { | |||
| // ------------ commit current offsets ---------------- | |||
|
|
|||
| // create copy of current offsets | |||
| //noinspection unchecked | |||
There was a problem hiding this comment.
Is this this is only suppressing IntellIJ warnings or is this meant to be a replacement for the @SuppressWarnings annotation?
There was a problem hiding this comment.
Its only supressing IntelliJ warnings I think. I don't know if we have any policy regarding this. The annotation will also suppress compiler warnings.
There was a problem hiding this comment.
I think you can remove the line after the annotation. I don't think we have a policy about this, but I've seen it in many places.
|
I tested the changes on the cluster with a job where I previously saw failures in zkClient. Now it seems to work. So I would give my :+1. Others would probably look at the implementation but that seems to be going on already. |
|
|
||
| private final CuratorFramework curatorClient; | ||
|
|
||
|
|
|
With Aljoscha's test +1 to merge (minus two trivial comments). |
|
Good fix, merging this! |
…ZK from Kafka This closes apache#1451
@aljoscha reported issues with our latest FlinkKafkaConnector: It was still throwing NPE.
Therefore, I decided to abandon the zkclient and use Apache Curator instead.