New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-20850][runtime] Removing usage of CoLocationConstraints #14584
Closed
Closed
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
d2cd2fc
[FLINK-20850][runtime] Remove ensureCoLocatedVerticesInSameRegion
XComp e676e69
[FLINK-20850][runtime] Remove CoLocationConstraint
XComp d606bd9
[FLINK-20850][runtime] Remove CoLocationConstraint-related test
XComp 343d47f
[FLINK-20850][runtime] Remove CoLocationConstraint-related test
XComp 5bd6cd9
[FLINK-20850][runtime] Remove CoLocation information from ExecutionVe…
XComp f4dcfd1
[FLINK-20850][runtime] Remove CoLocationConstraintTest
XComp 3645bcd
[FLINK-20850][runtime] Remove CoLocationConstraint from CoLocationGroup
XComp 22d847b
[FLINK-20850][runtime] Remove CoLocationConstraint
XComp b062aa5
[FLINK-20850][runtime] Make CoLocationGroupDesc an interface
XComp af31e07
[FLINK-20850][runtime] Minor cleanup
XComp ea4f9d4
[FLINK-20850][runtime] Cleans up resetForNewExecution
XComp ad854e3
[FLINK-20850][runtime] Replace CoLocationGroup by corresponding inter…
XComp ddfcfed
[FLINK-20850][runtime] Revert 8b1510c1
XComp f1b2df2
[FLINK-20850][runtime] Renames method
XComp 55c1b41
[FLINK-20850][runtime] Fix failing test
XComp acb1f1d
[FLINK-20850][runtime] Rename classes and interfaces
XComp 7dea123
[FLINK-20850][runtime] Typo fix
XComp 51e4355
[FLINK-20850][runtime] Apply renamings
XComp File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 0 additions & 56 deletions
56
...src/main/java/org/apache/flink/runtime/jobmanager/scheduler/CoLocationConstraintDesc.java
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be cleaner to add the
addVertex()
method to theCoLocationGroup
interface?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea was to have a readonly interface as the colocation groups do not need to be changed after initialization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, this is only the initialization.