-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-20911][state-backend-rocksdb] Support configuration of RocksDB log level #14614
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 926ffcf (Fri May 28 07:08:04 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI is broken due to bad format, please refactor this PR.
.noDefaultValue() | ||
.withDescription(String.format( | ||
"The specified log level for DB. Candidate log level is %s, %s, %s, %s, %s or %s, " | ||
+ "and Flink choose '%s' as default style. " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could remove this line as it add description of so Flink sets the RocksDB log level to HEADER_LEVEL by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Myasuka Thanks for your review. I have removed.
0df4cd1
to
879417b
Compare
How do you generate the configuration in html? |
879417b
to
f3a5b0e
Compare
f3a5b0e
to
926ffcf
Compare
@flinkbot run azure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Myasuka Thank you for your help and review. |
What is the purpose of the change
Support configuration of RocksDB log level
Brief change log
state.backend.rocksdb.log.level
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation