Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-20911][state-backend-rocksdb] Support configuration of RocksDB log level #14614

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

1996fanrui
Copy link
Member

What is the purpose of the change

Support configuration of RocksDB log level

Brief change log

  • add config state.backend.rocksdb.log.level

Verifying this change

This change added tests and can be verified as follows:

  • Check whether the configuration takes effect

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? docs

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 12, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 926ffcf (Fri May 28 07:08:04 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 12, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Member

@Myasuka Myasuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI is broken due to bad format, please refactor this PR.

.noDefaultValue()
.withDescription(String.format(
"The specified log level for DB. Candidate log level is %s, %s, %s, %s, %s or %s, "
+ "and Flink choose '%s' as default style. "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could remove this line as it add description of so Flink sets the RocksDB log level to HEADER_LEVEL by default.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Myasuka Thanks for your review. I have removed.

@1996fanrui 1996fanrui force-pushed the change-rocksdb-log-level branch 2 times, most recently from 0df4cd1 to 879417b Compare January 12, 2021 12:14
@1996fanrui
Copy link
Member Author

@Myasuka
The configuration of state.backend.rocksdb.log.level has added documentation, but the unit test of the documentation failed. I don't know how to solve it. Can you help me when you are free? Thanks.

link

@Myasuka
Copy link
Member

Myasuka commented Jan 13, 2021

How do you generate the configuration in html?
From the error message, it should be Flink choose 'HEADER_LEVEL' instead of Flink choose HEADER_LEVEL in your PR.

@1996fanrui
Copy link
Member Author

@flinkbot run azure

Copy link
Member

@Myasuka Myasuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Myasuka Myasuka merged commit 02a79de into apache:master Jan 15, 2021
@1996fanrui 1996fanrui deleted the change-rocksdb-log-level branch January 15, 2021 03:36
@1996fanrui
Copy link
Member Author

@Myasuka Thank you for your help and review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants