-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-20500][upsert-kafka] Fix temporal join test #14689
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 3e87860 (Fri May 28 07:11:18 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fsk119 for the contribution, the change look good to me, the PR description is really good, it's great if we can add some note I in the code for readable consideration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR description and thanks for digging into it.
LGTM.
What is the purpose of the change
The reason why the test fails is the records in the same partition are out-of-order. I print the partition-id and offset in the partition.
In the test, the expected record is
<10004,104,2020-08-16T00:05:06,Tomato,HONGKONG,2020-08-16T00:05:05>
but the actual record is<10004,104,2020-08-16T00:05:06,null,null,null>
.It may be the left stream record
<10004,104,2020-08-16T00:05:06>
arrives before the record<104,Tomato,Hongkong,HONGKONG,2020-08-16T00:05:05,1,4>
in the right stream. When the left stream arrives, it finds the watermark is at timestamp2020-08-16T01:04:05
in the right stream, which means the records before2020-08-16T01:04:05
have arrived and emits itself.Therefore, we should adjust the order in the partition or watermark strategy. Here we just adjust order for convenience. The new order in the partition follows.
Brief change log
Documentation