Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-21561] Predownload/Cache large E2E test artifacts #15086

Merged
merged 1 commit into from
Mar 19, 2021

Conversation

autophagy
Copy link
Contributor

What is the purpose of the change

This change aims to download and cache large E2E artifacts from archive.apache.org, to speed up subequent E2E tests. Instead of redownloading these files every time, they are downloaded to the e2e_artifact_cache folder and linked to where they are expected in the tests. Azure Pipelines will then cache these files, avoiding constant redownloading of hadoop, flink and confluent.

Brief change log

  • E2E test scripts have been modified to persist/cache large artifacts used between tests.

Verifying this change

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 4, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 3f85a1b (Thu Mar 04 10:13:29 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 4, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@zentol zentol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's another wget usage in elasticsearch-common that we could adjust as well.

flink-end-to-end-tests/download_artifacts.sh Outdated Show resolved Hide resolved
flink-end-to-end-tests/download_artifacts.sh Outdated Show resolved Hide resolved
@autophagy autophagy force-pushed the FLINK-21561 branch 2 times, most recently from 5c1ffe4 to ed55dd1 Compare March 7, 2021 09:52
@autophagy
Copy link
Contributor Author

@flinkbot run azure

@rmetzger
Copy link
Contributor

pushing (even an empty commit) is a much more reliable way of triggering azure builds

@autophagy autophagy force-pushed the FLINK-21561 branch 3 times, most recently from aa41c2e to 4caf272 Compare March 16, 2021 11:13
@autophagy autophagy force-pushed the FLINK-21561 branch 2 times, most recently from 8a20b81 to e202263 Compare March 17, 2021 20:56
@rmetzger
Copy link
Contributor

I manually re-triggered the failed test, because it failed somewhere else: https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=14919&view=results

@rmetzger
Copy link
Contributor

Thanks a lot for fixing this. Merging your PR now.

@rmetzger rmetzger merged commit 59832e1 into apache:master Mar 19, 2021
@autophagy autophagy deleted the FLINK-21561 branch March 19, 2021 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants