Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-23906][tests] Increase the default akka.ask.timeout for the MiniCluster to 5 minutes #16921

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

tillrohrmann
Copy link
Contributor

This commit sets the akka.ask.timeout, if not explicitly configured, to 5 minutes when using
the MiniCluster. The idea behind this change is to harden all our tests that rely on the MiniCluster
and run into TimeoutExceptions on our slow CI infrastructure.

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 5ae9f4c (Sat Aug 21 12:13:41 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 21, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@zentol zentol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should double-check that this change does not have a significant negative impact on the total test time.
Maybe it is just a fluke, but compared to the most recent run the testing times of all profiles have increased:

libraries: 16m -> 27m
table/connectors: 38m -> 54m

@tillrohrmann
Copy link
Contributor Author

Good point. I will rerun the change.

@flinkbot run azure.

Copy link
Contributor

@zentol zentol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking at the stages it looks like the tests themselves take roughly the same amount of time, but the install step sometimes needs way more time than usual (like, 40 instead of 4 minutes).

This is unlikely to be related and just some networking issues.

@tillrohrmann
Copy link
Contributor Author

Thanks for the review @zentol. Merging this PR now.

…niCluster to 5 minutes

This commit sets the akka.ask.timeout, if not explicitly configured, to 5 minutes when using
the MiniCluster. The idea behind this change is to harden all our tests that rely on the MiniCluster
and run into TimeoutExceptions on our slow CI infrastructure.

This closes apache#16921.
@tillrohrmann tillrohrmann merged commit c51fcda into apache:master Aug 24, 2021
@tillrohrmann tillrohrmann deleted the FLINK-23906 branch August 24, 2021 15:35
hhkkxxx133 pushed a commit to hhkkxxx133/flink that referenced this pull request Aug 25, 2021
…niCluster to 5 minutes

This commit sets the akka.ask.timeout, if not explicitly configured, to 5 minutes when using
the MiniCluster. The idea behind this change is to harden all our tests that rely on the MiniCluster
and run into TimeoutExceptions on our slow CI infrastructure.

This closes apache#16921.
niklassemmler pushed a commit to niklassemmler/flink that referenced this pull request Feb 3, 2022
…niCluster to 5 minutes

This commit sets the akka.ask.timeout, if not explicitly configured, to 5 minutes when using
the MiniCluster. The idea behind this change is to harden all our tests that rely on the MiniCluster
and run into TimeoutExceptions on our slow CI infrastructure.

This closes apache#16921.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants