-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-23906][tests] Increase the default akka.ask.timeout for the MiniCluster to 5 minutes #16921
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 5ae9f4c (Sat Aug 21 12:13:41 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should double-check that this change does not have a significant negative impact on the total test time.
Maybe it is just a fluke, but compared to the most recent run the testing times of all profiles have increased:
libraries: 16m -> 27m
table/connectors: 38m -> 54m
Good point. I will rerun the change. @flinkbot run azure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking at the stages it looks like the tests themselves take roughly the same amount of time, but the install step sometimes needs way more time than usual (like, 40 instead of 4 minutes).
This is unlikely to be related and just some networking issues.
Thanks for the review @zentol. Merging this PR now. |
…niCluster to 5 minutes This commit sets the akka.ask.timeout, if not explicitly configured, to 5 minutes when using the MiniCluster. The idea behind this change is to harden all our tests that rely on the MiniCluster and run into TimeoutExceptions on our slow CI infrastructure. This closes apache#16921.
5ae9f4c
to
c51fcda
Compare
…niCluster to 5 minutes This commit sets the akka.ask.timeout, if not explicitly configured, to 5 minutes when using the MiniCluster. The idea behind this change is to harden all our tests that rely on the MiniCluster and run into TimeoutExceptions on our slow CI infrastructure. This closes apache#16921.
…niCluster to 5 minutes This commit sets the akka.ask.timeout, if not explicitly configured, to 5 minutes when using the MiniCluster. The idea behind this change is to harden all our tests that rely on the MiniCluster and run into TimeoutExceptions on our slow CI infrastructure. This closes apache#16921.
This commit sets the akka.ask.timeout, if not explicitly configured, to 5 minutes when using
the MiniCluster. The idea behind this change is to harden all our tests that rely on the MiniCluster
and run into TimeoutExceptions on our slow CI infrastructure.