Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BP-1.13][FLINK-23906][tests] Increase the default akka.ask.timeout for the MiniCluster to 5 minutes #16922

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

tillrohrmann
Copy link
Contributor

Backport of #16921 to release-1.13.

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 2474a27 (Sat Aug 21 12:15:46 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 21, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@zentol
Copy link
Contributor

zentol commented Aug 22, 2021

[ERROR] /__w/3/s/flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniClusterConfiguration.java:[73,38] cannot find symbol
  symbol:   variable AkkaOptions
  location: class org.apache.flink.runtime.minicluster.MiniClusterConfiguration
[ERROR] /__w/3/s/flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniClusterConfiguration.java:[74,32] cannot find symbol
  symbol:   variable AkkaOptions
  location: class org.apache.flink.runtime.minicluster.MiniClusterConfiguration

@tillrohrmann
Copy link
Contributor Author

Thanks for the review @zentol. Merging this PR now.

…niCluster to 5 minutes

This commit sets the akka.ask.timeout, if not explicitly configured, to 5 minutes when using
the MiniCluster. The idea behind this change is to harden all our tests that rely on the MiniCluster
and run into TimeoutExceptions on our slow CI infrastructure.

This closes apache#16922.
@tillrohrmann tillrohrmann merged commit 2a388c5 into apache:release-1.13 Aug 24, 2021
@tillrohrmann tillrohrmann deleted the FLINK-23906-113 branch August 24, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants