-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-22791][docs] Documentation for HybridSource #16932
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 7b181d6 (Sun Aug 22 21:01:24 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
|
||
# Hybrid Source | ||
|
||
`HybridSource` is a source that contains a list of concrete sources. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it better to explain that this Source is a better point based on FLIP-27?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd not explicitly mention FLIP-27. Eventually source=FLIP-27, if we do a good enough job. But maybe we could link to https://ci.apache.org/projects/flink/flink-docs-release-1.13/docs/dev/datastream/sources/?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, added the link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some smaller suggestions.
|
||
# Hybrid Source | ||
|
||
`HybridSource` is a source that contains a list of concrete sources. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd not explicitly mention FLIP-27. Eventually source=FLIP-27, if we do a good enough job. But maybe we could link to https://ci.apache.org/projects/flink/flink-docs-release-1.13/docs/dev/datastream/sources/?
55c58bc
to
e6b9bb0
Compare
Thanks for the review and suggestions! @AHeise PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you very much.
I'm wondering if we should also tease the HybridSource
in the overview page. https://ci.apache.org/projects/flink/flink-docs-release-1.13/docs/connectors/datastream/overview/
It's very special since it's our first secondary source and folks may not know that they need it.
Good idea, I will take a look. |
Initial documentation for HybridSource (introduced in #15924).