Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-22791][docs] Documentation for HybridSource #16932

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

tweise
Copy link
Contributor

@tweise tweise commented Aug 22, 2021

Initial documentation for HybridSource (introduced in #15924).

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 7b181d6 (Sun Aug 22 21:01:24 UTC 2021)

Warnings:

  • Documentation files were touched, but no docs/content.zh/ files: Update Chinese documentation or file Jira ticket.
  • This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 22, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build


# Hybrid Source

`HybridSource` is a source that contains a list of concrete sources.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it better to explain that this Source is a better point based on FLIP-27?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd not explicitly mention FLIP-27. Eventually source=FLIP-27, if we do a good enough job. But maybe we could link to https://ci.apache.org/projects/flink/flink-docs-release-1.13/docs/dev/datastream/sources/?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, added the link

Copy link
Contributor

@AHeise AHeise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some smaller suggestions.

docs/content/docs/connectors/datastream/hybridsource.md Outdated Show resolved Hide resolved

# Hybrid Source

`HybridSource` is a source that contains a list of concrete sources.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd not explicitly mention FLIP-27. Eventually source=FLIP-27, if we do a good enough job. But maybe we could link to https://ci.apache.org/projects/flink/flink-docs-release-1.13/docs/dev/datastream/sources/?

docs/content/docs/connectors/datastream/hybridsource.md Outdated Show resolved Hide resolved
docs/content/docs/connectors/datastream/hybridsource.md Outdated Show resolved Hide resolved
@tweise tweise force-pushed the FLINK-22791.hybridsource-docs branch from 55c58bc to e6b9bb0 Compare August 23, 2021 16:55
@tweise
Copy link
Contributor Author

tweise commented Aug 23, 2021

Thanks for the review and suggestions!

@AHeise PTAL

Copy link
Contributor

@AHeise AHeise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much.

I'm wondering if we should also tease the HybridSource in the overview page. https://ci.apache.org/projects/flink/flink-docs-release-1.13/docs/connectors/datastream/overview/
It's very special since it's our first secondary source and folks may not know that they need it.

@tweise tweise merged commit fb7fbd8 into apache:master Aug 24, 2021
@tweise
Copy link
Contributor Author

tweise commented Aug 24, 2021

I'm wondering if we should also tease the HybridSource in the overview page. https://ci.apache.org/projects/flink/flink-docs-release-1.13/docs/connectors/datastream/overview/
It's very special since it's our first secondary source and folks may not know that they need it.

Good idea, I will take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants