-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-23750][docs][table] Add documentation for Window Top-N after Windowing TVF. #16983
Conversation
3443fcb
to
1261619
Compare
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 3443fcb (Wed Aug 25 12:34:42 UTC 2021) ✅no warnings Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
1261619
to
7244fd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @beyond1920 , LGTM overall
cc @wuchong |
@godfreyhe Thanks for review, I've updated, please have a look again, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some links are broken and docs can't build:
➜ docs git:(pull/16983) ✗ ./build_docs.sh
Start building sites …
WARN 2021/08/27 20:30:27 Expand shortcode is deprecated. Use 'details' instead.
ERROR 2021/08/27 20:30:28 [en] REF_NOT_FOUND: Ref "docs/dev/table/sql/queries/window-join": "/Users/wuchong/Workspace/Flink/flink/docs/content/docs/dev/table/sql/queries/window-topn.md:31:524": page not found
WARN 2021/08/27 20:30:30 Expand shortcode is deprecated. Use 'details' instead.
ERROR 2021/08/27 20:30:31 [zh] REF_NOT_FOUND: Ref "docs/dev/table/sql/queries/window-join": "/Users/wuchong/Workspace/Flink/flink/docs/content.zh/docs/dev/table/sql/queries/window-topn.md:31:524": page not found
Built in 5394 ms
Error: Error building site: logged 2 error(s)
Please preview the docs in local before submitting pull request.
b946f5e
to
caaedbb
Compare
caaedbb
to
77edfcd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What is the purpose of the change
The pr adds documentation for Window Top-N after Windowing TVF.
Brief change log
Window-topn.md
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation