-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-23287][docs][table] Create user document for Window Join in SQL #16997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit f5a35f4 (Thu Aug 26 11:19:30 UTC 2021) ✅no warnings Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @beyond1920 , LGTM overall
cc @wuchong |
@godfreyhe Thanks for review. I've updated, please have a look again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @beyond1920 , I left some comments.
@wuchong Thanks for review, I've updated. About |
@wuchong Thanks for review, I've updated. Please have a look. Thanks a lot. |
feab60e
to
717cc23
Compare
1d64f48
to
c096ede
Compare
@wuchong Jark, I've updated the input schema to use a lower-case and non-reserved-keyword as the field names. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually, we suggest to copy queries into SQL CLI and copy outputs to docs when writing examples.
@wuchong Thanks for suggestion, I've updated the results of sql query. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What is the purpose of the change
The pr adds documentation for Window join.
Brief change log
Window-join.md
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation