Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BP-1.14][FLINK-22002][tests] Let taskmanager.slot.timeout fall back to akka.ask.timeout #17109

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

tillrohrmann
Copy link
Contributor

Backport of #16995 to release-1.14.

@flinkbot
Copy link
Collaborator

flinkbot commented Sep 1, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 1a4b3ce (Wed Sep 01 20:26:23 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Sep 1, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

tillrohrmann added a commit to tillrohrmann/flink that referenced this pull request Sep 2, 2021
…sk.timeout

This commit lets taskmanager.slot.timeout fall to akka.ask.timeout so that the MiniCluster
will run by default with a 5 min taskmanager.slot.timeout. This should harden against CI
pauses.

This closes apache#17109.
@tillrohrmann
Copy link
Contributor Author

Thanks for the review @zentol. Merging this PR now.

…sk.timeout

This commit lets taskmanager.slot.timeout fall to akka.ask.timeout so that the MiniCluster
will run by default with a 5 min taskmanager.slot.timeout. This should harden against CI
pauses.

This closes apache#17109.
@tillrohrmann tillrohrmann merged commit ae4dfab into apache:release-1.14 Sep 2, 2021
@tillrohrmann tillrohrmann deleted the FLINK-22002-114 branch September 2, 2021 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants