Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-22002][tests] Let taskmanager.slot.timeout fall back to akka.ask.timeout #16995

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

tillrohrmann
Copy link
Contributor

This commit lets taskmanager.slot.timeout fall to akka.ask.timeout so that the MiniCluster
will run by default with a 5 min taskmanager.slot.timeout. This should harden against CI
pauses.

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit c827323 (Thu Aug 26 10:12:48 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 26, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

.durationType()
.defaultValue(TimeUtils.parseDuration("10 s"))
.noDefaultValue()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we explicitly configure this now in flink-conf.yaml to not change the current production behavior? (in particular for the 1.13 backport)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure whether this change made sense in the first place, tbh. Per default you probably want to have the same timeout as you give your RPCs. If you want to have a smaller timeout, then you configure it explicitly.

@tillrohrmann
Copy link
Contributor Author

@flinkbot run azure.

@tillrohrmann
Copy link
Contributor Author

The build is now passing. The problem was that the taskmanager.slot.timeout did not have a default value. Feel free to give it another pass @zentol.

@tillrohrmann
Copy link
Contributor Author

Thanks for the review @zentol. Merging this PR now.

…sk.timeout

This commit lets taskmanager.slot.timeout fall to akka.ask.timeout so that the MiniCluster
will run by default with a 5 min taskmanager.slot.timeout. This should harden against CI
pauses.

This closes apache#16995.
@tillrohrmann tillrohrmann merged commit 67a16b0 into apache:master Sep 2, 2021
@tillrohrmann tillrohrmann deleted the FLINK-22002 branch September 2, 2021 13:57
niklassemmler pushed a commit to niklassemmler/flink that referenced this pull request Feb 3, 2022
…sk.timeout

This commit lets taskmanager.slot.timeout fall to akka.ask.timeout so that the MiniCluster
will run by default with a 5 min taskmanager.slot.timeout. This should harden against CI
pauses.

This closes apache#16995.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants