-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-22002][tests] Let taskmanager.slot.timeout fall back to akka.ask.timeout #16995
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit c827323 (Thu Aug 26 10:12:48 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
.durationType() | ||
.defaultValue(TimeUtils.parseDuration("10 s")) | ||
.noDefaultValue() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we explicitly configure this now in flink-conf.yaml to not change the current production behavior? (in particular for the 1.13 backport)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure whether this change made sense in the first place, tbh. Per default you probably want to have the same timeout as you give your RPCs. If you want to have a smaller timeout, then you configure it explicitly.
@flinkbot run azure. |
c827323
to
62b66e5
Compare
The build is now passing. The problem was that the |
Thanks for the review @zentol. Merging this PR now. |
…sk.timeout This commit lets taskmanager.slot.timeout fall to akka.ask.timeout so that the MiniCluster will run by default with a 5 min taskmanager.slot.timeout. This should harden against CI pauses. This closes apache#16995.
62b66e5
to
67a16b0
Compare
…sk.timeout This commit lets taskmanager.slot.timeout fall to akka.ask.timeout so that the MiniCluster will run by default with a 5 min taskmanager.slot.timeout. This should harden against CI pauses. This closes apache#16995.
This commit lets taskmanager.slot.timeout fall to akka.ask.timeout so that the MiniCluster
will run by default with a 5 min taskmanager.slot.timeout. This should harden against CI
pauses.